bf89a23d91
When evacuating an instance the evacuation migration record moves from a state of `accepted` to `pre-migrating` and eventually `done` once the instance has been rebuilt on the new compute host. At present the migration record remains in this state until the original compute host is restarted and the service cleans up any leftovers of the instance before it is moved to a state of `completed`. Bug #1922053 details a use case where an operator might unintentionally forget to ensure the compute service is restarted before forcing the service up leaving evacuation migration records stuck as `done`. This could become an issue in the future if the instance is moved back to this compute before the service is restarted. Any future restart invoking the cleanup logic and potentially damaging the running instance. This change aims to address this by blocking requests to force up computes associated to `done` evacuation records. Forcing operators to restart the service allowing them to move to a `completed` state before the service can be forced up again. To allow this to be backportable these requests are rejected with a 400 BadRequest return code from the API. A TODO is left to move this to a 409 Conflict during the Xena release under a new microversion. Finally, some additional functional tests have been updated to ensure they restart the source compute service of an evacuation before attempting to force up the service, ensuring any migration records are marked as completed. Closes-Bug: #1922053 Change-Id: I95882ea28564a31a6b4f8b665de462774d84edfc |
||
|---|---|---|
| .. | ||
| README.rst | ||
| __init__.py | ||
| test_bug_1404867.py | ||
| test_bug_1522536.py | ||
| test_bug_1541691.py | ||
| test_bug_1548980.py | ||
| test_bug_1552888.py | ||
| test_bug_1554631.py | ||
| test_bug_1558866.py | ||
| test_bug_1568208.py | ||
| test_bug_1595962.py | ||
| test_bug_1620248.py | ||
| test_bug_1669054.py | ||
| test_bug_1670627.py | ||
| test_bug_1671648.py | ||
| test_bug_1675570.py | ||
| test_bug_1678326.py | ||
| test_bug_1679750.py | ||
| test_bug_1682693.py | ||
| test_bug_1689692.py | ||
| test_bug_1702454.py | ||
| test_bug_1713783.py | ||
| test_bug_1718455.py | ||
| test_bug_1718512.py | ||
| test_bug_1719730.py | ||
| test_bug_1732947.py | ||
| test_bug_1735407.py | ||
| test_bug_1741125.py | ||
| test_bug_1741307.py | ||
| test_bug_1746483.py | ||
| test_bug_1764556.py | ||
| test_bug_1764883.py | ||
| test_bug_1778305.py | ||
| test_bug_1780373.py | ||
| test_bug_1781286.py | ||
| test_bug_1781710.py | ||
| test_bug_1784353.py | ||
| test_bug_1790204.py | ||
| test_bug_1794996.py | ||
| test_bug_1797580.py | ||
| test_bug_1806064.py | ||
| test_bug_1806515.py | ||
| test_bug_1815153.py | ||
| test_bug_1823370.py | ||
| test_bug_1825020.py | ||
| test_bug_1825034.py | ||
| test_bug_1825537.py | ||
| test_bug_1830747.py | ||
| test_bug_1831771.py | ||
| test_bug_1835822.py | ||
| test_bug_1837955.py | ||
| test_bug_1839560.py | ||
| test_bug_1843090.py | ||
| test_bug_1843708.py | ||
| test_bug_1845291.py | ||
| test_bug_1848343.py | ||
| test_bug_1849165.py | ||
| test_bug_1849409.py | ||
| test_bug_1852458.py | ||
| test_bug_1862633.py | ||
| test_bug_1879878.py | ||
| test_bug_1886418.py | ||
| test_bug_1888395.py | ||
| test_bug_1889108.py | ||
| test_bug_1893284.py | ||
| test_bug_1894966.py | ||
| test_bug_1895696.py | ||
| test_bug_1896463.py | ||
| test_bug_1899649.py | ||
| test_bug_1899835.py | ||
| test_bug_1902925.py | ||
| test_bug_1908075.py | ||
| test_bug_1909120.py | ||
| test_bug_1914777.py | ||
| test_bug_1922053.py | ||
README.rst
Tests for Specific Regressions
When we have a bug reported by end users that we can write a full stack reproduce on, we should. And we should keep a regression test for that bug in our tree. It can be deleted at some future date if needed, but largely should not be changed.
Writing Regression Tests
- These should be full stack tests which inherit from nova.test.TestCase directly. (This is to prevent coupling with other tests).
- They should setup a full stack cloud in their setUp via fixtures
- They should each live in a file which is named test_bug######.py
Writing Tests Before the Bug is Fixed
TODO describe writing and landing tests before the bug is fixed as a reproduce.