This builds on I0bd63b655ad3d3d39af8d15c781ce0a45efc8e3a
which made DELETE /os-services/{service_id} fail with a 409
response if the host has instances on it. This change checks
for in-progress migrations involving the nodes on the host,
either as the source or destination nodes, and returns a 409
error response if any are found.
Failling to do this can lead to orphaned resource providers
in placement and also failing to properly confirm or revert
a pending resize or cold migration.
A release note is included for the (justified) behavior
change in the API. A new microversion should not be required
for this since admins should not have to opt out of broken
behavior.
Conflicts:
nova/tests/functional/integrated_helpers.py
NOTE(mriedem): The conflict is due to change
Iec61f56c05e06924def814a3a6e09ceb91a15894 which is not in Train.
NOTE(mriedem): services.py had to be updated to add the LOG
variable since change I8403a841f21a624a546ae5f26bb9ba19318ece6a
is not in Train.
Change-Id: I70e06c607045a1c0842f13069e51fef438012a9c
Closes-Bug: #1852610
(cherry picked from commit 92fed02610)
a9650b3cbf