openstack
/
nova
Code Issues Proposed changes
nova/nova/tests/unit/virt/xenapi
History
Corey Bryant 5b0adaa0ca xenapi/agent: Change openssl error handling 
Prior to this patch, if the openssl command returned a zero exit code
and wrote details to stderr, nova would raise a RuntimeError exception.
This patch changes the behavior to only raise a RuntimeError exception
when openssl returns a non-zero exit code. Regardless of the exit code
a warning will always be logged with stderr details if stderr is not
None. Note that processutils.execute will now raise a
processutils.ProcessExecutionError exception for any non-zero exit code
since we are passing check_exit_code=True, which we convert to a
Runtime error.

Thanks to Dimitri John Ledkov <xnox@ubuntu.com> and Eric Fried
<openstack@fried.cc> for helping with this patch.

Conflicts:
    nova/virt/xenapi/agent.py

NOTE(coreycb): The conflict is due to
Ibe2f478288db42f8168b52dfc14d85ab92ace74b not being in stable/queens.

Change-Id: I212ac2b5ccd93e00adb7b9fe102fcb70857c6073
Partial-Bug: #1771506
(cherry picked from commit 1da71fa4ab)
(cherry picked from commit 64793cf6f7)
(cherry picked from commit 82de38ad4c)
 		2019-04-30 09:07:53 -04:00
..
image Don't fix protocol-less glance api_servers anymore 2017-10-10 13:03:26 +00:00
__init__.py
…
stubs.py Deprecate xenserver.vif_driver config option and change default 2017-02-16 12:15:12 -05:00
test_agent.py xenapi/agent: Change openssl error handling 2019-04-30 09:07:53 -04:00
test_driver.py XenAPI: create vGPU for instance 2017-12-18 08:09:20 -08:00
test_network_utils.py
…
test_vgpu.py XenAPI: create vGPU for instance 2017-12-18 08:09:20 -08:00
test_vif.py XenAPI: Don't use nicira-iface-id for XenServer VIF 2017-12-06 15:48:12 +00:00
test_vm_utils.py Move remaining uses of parted to privsep. 2018-01-24 22:26:36 +00:00
test_vmops.py xenapi: handle InstanceNotFound in detach_interface() 2018-04-26 11:18:20 +00:00
test_volume_utils.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
test_volumeops.py refactor: move down ``dev_number`` in xenapi 2016-12-05 13:19:23 -06:00
test_xenapi.py XenAPI: Unit tests must mock os_xenapi calls 2017-12-28 23:11:47 +00:00
vm_rrd.xml
…