nova/nova/tests/unit
rsritesh d89e7d7857 libvirt: flatten rbd images when unshelving an instance
Previously attempts to remove the shelved snapshot of an unshelved
instance when using the rbd backends for both Nova and Glance would
fail. This was due to the instance disk being cloned from and still
referencing the shelved snapshot image in Glance, blocking any attempt
to remove this image later in the unshelve process.

After much debate this change attempts to fix this issue by flattening
the instance disk while the instance is being spawned as part of an
unshelve. For the rbd imagebackend this removes any reference to the
shelved snapshot in Glance allowing this image to be removed. For all
other imagebackends the call to flatten the image is currently a no-op.

Co-Authored-By: Lee Yarwood <lyarwood@redhat.com>
Co-Authored-By: Vladyslav Drok <vdrok@mirantis.com>

Closes-Bug: #1653953
Change-Id: If3c9d1de3ce0fe394405bd1e1f0fa08ce2baeda8
2019-06-27 09:52:45 +01:00
..
api Merge "Delete resource providers for all nodes when deleting compute service" 2019-06-21 08:22:07 +00:00
cmd conf: Remove cells v1 options, group 2019-05-29 17:14:13 +01:00
compute Merge "Revert "Revert resize: wait for events according to hybrid plug"" 2019-06-24 19:14:34 +00:00
conductor Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' 2019-06-12 16:09:46 +01:00
conf Assorted cleanups from numa-aware-vswitches series 2018-07-27 09:49:12 -07:00
console Add 'path' query parameter to console access url 2019-06-14 18:01:24 +00:00
consoleauth Stop handling cells v1 for console authentication 2019-04-16 18:26:17 +01:00
db Merge "Simplfy test setup for TestNovaMigrations* tests" 2019-06-22 01:31:28 +00:00
fake_loadables
image Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00
keymgr
network Revert "Revert resize: wait for events according to hybrid plug" 2019-06-24 14:24:15 +00:00
notifications extend libvirt video model support 2019-06-21 16:53:37 +01:00
objects Merge "[FUP] fix backleveling unit test for video models" 2019-06-24 13:33:51 +00:00
pci Move selective patching of open() to nova.test for reuse 2019-05-25 02:49:40 +00:00
privsep Merge "Fix invalid privsep.readpty test" 2019-06-14 21:52:56 +00:00
scheduler Merge "Avoid unnecessary joins in delete_resource_provider" 2019-06-21 08:32:41 +00:00
servicegroup Fix deprecation warning for threadgroup.add_timer 2019-02-07 09:37:00 -05:00
ssl_cert
virt libvirt: flatten rbd images when unshelving an instance 2019-06-27 09:52:45 +01:00
volume Keep attach_mode as top-level field in _translate_attachment_ref 2019-05-22 09:09:37 +00:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py Change the default of notification_format to unversioned 2019-06-04 10:36:45 +02:00
fake_block_device.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_build_request.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_console_auth_token.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_crypto.py
fake_diagnostics.py
fake_flavor.py
fake_hosts.py
fake_instance.py Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize 2019-05-30 09:32:21 -04:00
fake_ldap.py
fake_network.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_network_cache_model.py
fake_notifier.py Fix jsonutils.to_primitive UserWarning 2018-12-17 22:56:50 -05:00
fake_pci_device_pools.py
fake_policy.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
fake_processutils.py
fake_request_spec.py Fix resetting non-persistent fields when saving obj 2019-02-26 09:26:52 +09:00
fake_requests.py
fake_server_actions.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
fake_volume.py Use uuidsentinel from oslo.utils 2018-09-05 09:08:54 -05:00
fake_xvp_console_proxy.py
image_fixtures.py Merge image_size extension response into image view builder 2018-10-18 01:59:34 +00:00
matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
policy_fixture.py Delete the placement code 2019-04-28 20:06:15 +00:00
test_api_validation.py Remove '/os-cells' REST APIs 2019-04-16 18:26:13 +01:00
test_availability_zones.py Always pass HostAPI to get_availability_zones 2019-04-26 15:30:48 -04:00
test_baserpc.py
test_block_device.py Add method to generate device names universally 2019-01-15 18:55:11 +00:00
test_cache.py
test_cinder.py Make [cinder]/catalog_info no longer require a service_name 2018-11-28 18:33:30 -05:00
test_conf.py Delete the placement code 2019-04-28 20:06:15 +00:00
test_configdrive2.py
test_context.py Revert "Fix target_cell usage for scatter_gather_cells" 2019-05-08 02:46:50 +00:00
test_crypto.py
test_exception.py Convert exception messages to strings 2018-11-05 14:21:02 +02:00
test_fake_notifier.py Raise error on timeout in wait_for_versioned_notifications 2018-09-29 00:29:49 +01:00
test_fixtures.py Fix SynchronousThreadPoolExecutorFixture mock of Future 2019-05-08 02:46:50 +00:00
test_flavors.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_hacking.py Merge "Hacking N363: `in (not_a_tuple)`" 2019-06-14 22:07:58 +00:00
test_hooks.py
test_identity.py Adapter raise_exc=False by default 2018-06-22 09:40:33 -05:00
test_instance_types_extra_specs.py
test_iptables_network.py
test_ipv6.py
test_json_ref.py
test_loadables.py
test_matchers.py fix bug with XML matcher handling missing children 2019-03-01 18:19:01 +00:00
test_metadata.py Ensure that metadata proxy raises correct exception 2019-05-27 03:50:44 -07:00
test_notifications.py Remove deprecated 'default_flavor' config option 2019-04-30 13:01:40 +00:00
test_notifier.py
test_nova_manage.py Warn for duplicate host mappings during discover_hosts 2019-06-13 17:18:16 +00:00
test_policy.py Remove cells code 2019-05-20 10:29:16 +01:00
test_profiler.py Remove cells code 2019-05-20 10:29:16 +01:00
test_quota.py Log quota legacy method warning only if counting from placement 2019-06-17 21:31:53 +00:00
test_rpc.py test_rpc: Stop f****** with global state 2019-04-26 12:21:16 +01:00
test_safeutils.py
test_service.py Move conductor wait_until_ready() delay before manager init 2018-08-31 12:50:10 -07:00
test_service_auth.py
test_test.py Move selective patching of open() to nova.test for reuse 2019-05-25 02:49:40 +00:00
test_test_utils.py Use nova.db.api directly 2018-07-10 14:56:27 +00:00
test_utils.py Merge "Mock time.sleep() in unit tests" 2019-06-14 21:53:17 +00:00
test_versions.py Move selective patching of open() to nova.test for reuse 2019-05-25 02:49:40 +00:00
test_weights.py Per aggregate scheduling weight 2019-01-21 11:48:44 +08:00
test_wsgi.py
utils.py Bump to hacking 1.1.0 2019-04-12 16:23:49 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎