787bb33606
Adjust the fixtures used by the functional tests so they use placement database and web fixtures defined by placement code. To avoid making redundant changes, the solely placement- related unit and functional tests are removed, but the placement code itself is not (yet). openstack-placement is required by the functional tests. It is not added to test-requirements as we do not want unit tests to depend on placement in any way, and we enforce this by not having placement in the test env. The concept of tox-siblings is used to ensure that the placement requirement will be satisfied correctly if there is a depends-on. To make this happen, the functional jobs defined in .zuul.yaml are updated to require openstack/placement. tox.ini has to be updated to use a envdir that is the same name as job. Otherwise the tox siblings role in ansible cannot work. The handling of the placement fixtures is moved out of nova/test.py into the functional tests that actually use it because we do not want unit tests (which get the base test class out of test.py) to have anything to do with placement. This requires adjusting some test files to use absolute import. Similarly, a test of the comparison function for the api samples tests is moved into functional, because it depends on placement functionality, TestUpgradeCheckResourceProviders in unit.cmd.test_status is moved into a new test file: nova/tests/functional/test_nova_status.py. This is done because it requires the PlacementFixture, which is only available to functional tests. A MonkeyPatch is required in the test to make sure that the right context managers are used at the right time in the command itself (otherwise some tables do no exist). In the test itself, to avoid speaking directly to the placement database, which would require manipulating the RequestContext objects, resource providers are now created over the API. Co-Authored-By: Balazs Gibizer <balazs.gibizer@ericsson.com> Change-Id: Idaed39629095f86d24a54334c699a26c218c6593 |
||
|---|---|---|
| .. | ||
| README.rst | ||
| __init__.py | ||
| test_bug_1404867.py | ||
| test_bug_1522536.py | ||
| test_bug_1541691.py | ||
| test_bug_1548980.py | ||
| test_bug_1552888.py | ||
| test_bug_1554631.py | ||
| test_bug_1558866.py | ||
| test_bug_1568208.py | ||
| test_bug_1595962.py | ||
| test_bug_1620248.py | ||
| test_bug_1670627.py | ||
| test_bug_1671648.py | ||
| test_bug_1675570.py | ||
| test_bug_1678326.py | ||
| test_bug_1679750.py | ||
| test_bug_1682693.py | ||
| test_bug_1689692.py | ||
| test_bug_1702454.py | ||
| test_bug_1713783.py | ||
| test_bug_1718455.py | ||
| test_bug_1718512.py | ||
| test_bug_1719730.py | ||
| test_bug_1732947.py | ||
| test_bug_1735407.py | ||
| test_bug_1741125.py | ||
| test_bug_1741307.py | ||
| test_bug_1746483.py | ||
| test_bug_1746509.py | ||
| test_bug_1764883.py | ||
| test_bug_1780373.py | ||
| test_bug_1781710.py | ||
| test_bug_1784353.py | ||
| test_bug_1794996.py | ||
| test_bug_1797580.py | ||
| test_bug_1806064.py | ||
| test_bug_1806515.py | ||
README.rst
Tests for Specific Regressions
When we have a bug reported by end users that we can write a full stack reproduce on, we should. And we should keep a regression test for that bug in our tree. It can be deleted at some future date if needed, but largely should not be changed.
Writing Regression Tests
- These should be full stack tests which inherit from nova.test.TestCase directly. (This is to prevent coupling with other tests).
- They should setup a full stack cloud in their setUp via fixtures
- They should each live in a file which is named test_bug######.py
Writing Tests Before the Bug is Fixed
TODO describe writing and landing tests before the bug is fixed as a reproduce.