This patch introduces stricter checking on fields that are in
lookup tables, but are effectively Enum fields. Because we do a
lot of case-sensitive string comparisons against these fields in
various places throughout the code tree, but because SQL does not
to case-sensitive comparisons by default, it's important that we
are case-sensitive in the API for these fields.
Change-Id: Ib23796754ca54f69bb60c79c75804a5e7ee26e29
Closes-Bug:1534217
Once we add debug testenv, we can use "tox -e debug -- --debug"
to debug test cases when tox is running.
Change-Id: Ic0635f2b99c166c77757277e8273f42cdb17ce73
os.popen() is deprecated since version 2.6. Resolved with use of
subprocess module.
Closes-bug: #1529836
Change-Id: Ibdb8f13462e8416097006e19eb2214425364910e
When running the health manager on single host devstack machine, the
hosts IP cannot simply be used as if the health manager is running
on a host by itself. The solution here is to create a neutron port
on the lb-mgmt-net which sets up necessary ovs ports and also
reserves an IP. Then the script creates an ovs port for and sets
and interface with the information the neutron port create allocated.
There are some flaws with this but its a starting point and can and
probably will be improved on in the future. However it works for
now.
Change-Id: Ic3d3d1d63a5cc352c5fc00dea58bb16915754a7c
Closes-Bug: #1490033
We have an IdMixin. All the other objects with an ID here use it.
No point in inconsistently defining 'id' with the Amphora model.
Change-Id: I7758c08536e13d3ef653a604bcc74e1896c7d143
Each config option has limitation for type and value.
In production code, oslo.conf can ensure user's input
is valid, but in unit test, test methods can pass if
we use method CONF.set_override without parameter
enforce_type=True even we pass wrong type or wrong
value to config option. This commit makes sure calling
method CONF.set_override with enforce_type=True.
Change-Id: I1e4f2aa5797ba8582a5637cd86c6b2b626daa923
Closes-Bug: #1517839
This makes more sense and also suppresses the error messages when
launching the service returned from oslo_messaing.get_rpc_server
service. Instead of that service wait() being called, the Consumer's
wait will be called.
Change-Id: I63816e92fbe26a4213946e6ab584531bdc3b7dd2
Closes-Bug: #1527418
There were some bad unit tests that would fail depending on the test
order. This would intermittently cause gate failures.
This patch corrects those unit tests.
Closes-Bug: #1526942
Change-Id: Id80a0a1a71a8248e5709f7df8c9af6a93a412f93
This patch fixes two things:
1. The sysctl settings were failing because some conntrack modules
were not loaded anymore.
2. I fixed the sysctl-set-value scripts to be able to handle
multi-value settings, such as tcp_rmem, in tripleo-image-elements[1].
Here I have removed the workaround we had in Octavia.
[1] https://review.openstack.org/#/c/134616/
Change-Id: Ib7ab4f487c1b792b70a110098bf7a28cb565ee55
Closes-Bug: #1527392
Current code to install diskimage-builder requirements in
devstack does not pass on enviroment settings to sudo, which can
cause the pip install to fail behind a proxy.
This happens when the user has http_proxy/https_proxy values set
but not for root. The stack.sh runs and installs for a while,
before failing on the Octavia diskimage-builder.
Change-Id: I196aca7004ea0eed713877e54ba10dcfe1d343e7
Closes-Bug: #1526108
The project_id (formerly tenant_id) was not actually allowed as an
attribute of any entity on create nor would it be returned as details
of an entity. project_id will be used in the future and is just
overall good to have.
This also accepts request headers to set the project_id if they are passed in
and no tenant_id is provided in the body.
Change-Id: I6408b7863409870b502de03af35692b065b2c6dc
This was meant to be done in a prior review but the author of that review (me)
was not thinking clearly when he did not include them as part of that rename.
Change-Id: Ibae52777921adcfa3e6835274d61670b4091ca39
flows have been optimized to limit the amount of data being stored.
* member object is stored in flow, hence member_id can easily be retrieved
* same with vip and load_balancer
Change-Id: I85c1f55dc7faa412dcb649bd09a845c674ea853c
Closes-Bug: #1461686
There is now a new configuration option "barbican_auth" in the
certificates section, to specify which auth plugin to use when
communicating with Barbican. This is because the default option (using
ACLs inside Barbican to control access) should be ok as a default
workflow, but it might be required to use other methods depending on
your deployment. For example, another possible auth method would be
BarbicanTrustAuth, utilizing Keystone Trusts.
Some deployers may need custom auth methods that do not exist in
upstream Keystone, and will need their own Auth plugin. This should be in line
with the way Octavia's network and compute drivers work already.
While we're in this file, prune the unused (and really bad) method that
would *actually* delete certs from Barbican (not in our scope).
Also do the tenant_id -> project_id rename.
Change-Id: Ic9aef68924bb5c216734afd25403e59476c576e7
upstart was hardcoded as the means of start, stopping and reloading
of haproxy. Allow for sysvinit scripts and paths to handle haproxy.
This patch provides a configuration option to switch
between the defaultl upstart init scripts or sysvinit.
Change-Id: I9efe51c5a08d8e2268150d69ac25725c708dfb8e
Since openstack is going through renaming tenants to projects
it is best that we do this now while its easier before it becomes
bigger and harder to do.
This also adds project_id to the health_monitor table and models
since this seemed like an oversight.
Change-Id: Icc8034dcb517a3f8d218d83c94e4a2dcc977cc29
This patch enables nopreempt for active/standby topology amphora.
This reduces the need to migrate the IP between the active and standby
amphora. This is important for amphora that are using TLS offload.
When a MASTER amphora fails over to a BACKUP amphora the IP address
migrates to the BACKUP which becomes the new MASTER.
With this patch, should the original MASTER come back up, the IP will not
migrate back to the original MASTER until the BACKUP fails.
Current behavior is when the original MASTER comes back up the IP
will migrate back to it.
Change-Id: Ib9f5ecd92f37299c7ae5cbb607f4f9df9106409f
