3015 Commits

Author SHA1 Message Date
Carlos Goncalves
8178bd37a2 Fix name of VRRP configuration option
The provided etc/octavia.conf file is typically installed by system
packages. It is important to set correct configuration option names and
default values even when commented out.

Task: 37525
Story: 2006891

Change-Id: Ia9da64d76e31422464af9d24b675094f25350f48
2019-11-17 15:43:17 +01:00
Zuul
42bb73d364 Merge "Fix filtering for provider capabilities list API" 2019-11-16 03:24:53 +00:00
Zuul
31139e61c8 Merge "Fix a potential race condition with certs-ramfs" 2019-11-15 13:34:35 +00:00
Zuul
01a3ed55db Merge "Fix listeners with SNI certificates" 2019-11-14 20:43:30 +00:00
Michael Johnson
28c936ec71 Fix filtering for provider capabilities list API
The "Show Provider Flavor Capabilities" would silently ignore
filtering parameters passed into the API. This patch corrects this
such that you can filter the providers capabilities list.

Change-Id: I9a2aa4ed5b4ef60545c60a6d5bd06066ef361a56
Story: 2006817
Task: 37377
2019-11-12 21:39:50 +00:00
Michael Johnson
1900ee71a5 Fix a potential race condition with certs-ramfs
There is a potential race condition in the start order for the
amphora-agent service and the certs-ramfs service.
This patch configures an explict ordering for the services.

Change-Id: I8e449b19af72d72f6effd52e0a2debb5754a19b3
Story: 2006823
Task: 37396
2019-11-11 13:45:35 -08:00
Zuul
51425dcda6 Merge "Fix typo in doc agent.py->agent" 2019-11-11 17:43:29 +00:00
Colin Gibbons
0682fb977a ipvsadm '--exact' arg to ensure outputs are ints
Currently the keepalivedlvs_query script calls ipvsadm -Ln --stats
to query the local lvs for connection information. If any of these
values grow large enough they will be abbreviated with human-
friendly suffixes (K, M, G) and cause the get_ipvsadm_info func
to raise an exception when it receives a non-integer value from
its command output. By using the --exact argument in addition to
the existing arguments, we can ensure the output is always expanded
numbers, per the ipvsadm man page, and will only ever offer integer
outputs to the get_ipvsadm_info command.

Change-Id: I2e8c0be2221c0c23b752fdf2cdff065cddf830a5
Story: 2006791
Task: 37331
2019-11-06 09:24:30 -08:00
Zuul
43577a6c04 Merge "Fix batch member update error on empty change list" 2019-10-28 13:34:13 +00:00
Michael Johnson
3c05ce1297 Fix listeners with SNI certificates
The single process patch changed the way listeners and load balancers
are deployed inside the amphora. This caused listeners with SNI
enabled to load all of the certificates for all of the TLS enabled
listeners on a load balancer.
This patch corrects that by configuring each listener with a
specific list of certificates.

Change-Id: I2f3c7ab4137dbd84d77a6a6b675975af406249d0
Story: 2006758
Task: 37252
2019-10-25 14:15:48 -07:00
Ajay Kumar
935567b84c Fix typo in doc agent.py->agent
This patch fix the wrong description of agent_server_cert

Change-Id: I79979198e6cb4ee8c6ad49a7b9bd8e4093cf1934
Story: 2006612
Task: 36797
2019-10-24 14:27:27 +05:30
Zuul
93a7116b54 Merge "Fix some plug.py unit tests that broke on OSX" 2019-10-23 21:27:09 +00:00
Zuul
6a15e14d25 Merge "Allow IPv6 health network in devstack" 2019-10-23 09:20:33 +00:00
Zuul
d775d95fb9 Merge "Do not set log format when 'no log' is set" 2019-10-23 08:40:56 +00:00
Zuul
19789839f6 Merge "[Trivial]Add missing ws between words" 2019-10-23 05:33:18 +00:00
zhufl
28694f0233 [Trivial]Add missing ws between words
This is to add missing ws between words in help messages.

Change-Id: Iedb0e9f5414a9fd82e189c71e565ac0771a1482d
2019-10-22 11:51:43 +08:00
Zuul
6b58e66868 Merge "Add Gentoo platform detection in diskimage-create/diskimage-create.sh" 2019-10-22 03:28:58 +00:00
Adam Harwell
01dfb8ffaf Fix batch member update error on empty change list
If the list of changes was empty, the worker would fail to fetch the
pool because it was retrieved implicitly from one of the changed
members. Pass it explicitly instead, and also short-circuit on NOOPs.

Story: 2006719
Task: 37090

Depends-On: https://review.opendev.org/#/c/688546/
Change-Id: I161a522abad4a2aa521ea46cb1065c5b05a2cd2e
2019-10-21 22:51:27 +00:00
Adam Harwell
ca4b3d379d Fix some plug.py unit tests that broke on OSX
Mocks were done slightly incorrectly for pyroute2, correct this and add
a missing mock for os.path.isfile since it only coincidentally worked.

Change-Id: Id178784ebb4a9da348d295201fd6aa715c5b4abe
2019-10-21 22:47:54 +00:00
Adam Harwell
2c6d8fc5ec Allow IPv6 health network in devstack
This allows the Octavia devstack plugin to use IPv6 for the service
endpoint as well as for the lb-mgmt-net.

Co-Authored-By: Michael Johnson <johnsomor@gmail.com>

Change-Id: I87917440565ea953ec0d762a7e219d912c56c418
2019-10-21 22:47:28 +00:00
Zuul
ae9895adcc Merge "Fix log offload file permissions in CentOS devstack" 2019-10-21 21:37:37 +00:00
Zuul
5979f2c63c Merge "Delete the periodic Fedora 28 amphora image job" 2019-10-21 18:23:44 +00:00
Michael Johnson
7fcef817ec Fix issues with unavailable secrets
Previously, if a secret became unavailable in barbican, the user saw
a generic error raised from the barbican client and was unable to delete
load balancer resources. This patch corrects both of those issues.

Change-Id: I97bd1b2a97a44d0a0566ae56167fa4f2e503ee2d
Story: 2006676
Task: 37012
Task: 37077
2019-10-19 01:09:07 +00:00
Zuul
2f1987ccbe Merge "Revert "Clean up requirements.txt from tox.ini"" 2019-10-19 01:02:47 +00:00
Michael Johnson
fce2cd4f49 Revert "Clean up requirements.txt from tox.ini"
It appears that these are required to have the upper constraints properly applied. We need to revert this change.

This reverts commit 7b8e6de1b8230e5d31ca36624e7fdfba25e3e077.

Change-Id: I4941df3894148482c597d30f3a8db70659fd1b7a
2019-10-18 20:55:45 +00:00
Michael Johnson
076c3adc36 Add backend re-encryption to the LB cookbook
This patch adds a cookbook section for creating backend re-encryption
pools with optional client authentication.

Change-Id: If2a732d7b692f3cd6c422efbb1f71103ffecc4c9
2019-10-15 15:00:10 -07:00
Michael Johnson
4b4638e67d Add client authentication to the LB cookbook
This patch adds a cookbook section for creating client authentication
enabled listeners.

It also removes two references to granting access to secrets in
barbican that are no longer required.

Change-Id: Iaada1b5d519bfc57528aa15bae8c0ee2b55f0567
2019-10-15 13:45:55 -07:00
Zuul
25c31fe6d2 Merge "Use bandit block in tox.ini" 2019-10-14 22:50:27 +00:00
Zuul
3177aade97 Merge "Clean up requirements.txt from tox.ini" 2019-10-14 13:43:39 +00:00
Zuul
bbbf4fbe5c Merge "Switch to openstack-python3-ussuri-jobs" 2019-10-12 12:40:43 +00:00
Zuul
e842d739a2 Merge "Update the load balancing cookbook" 2019-10-12 12:40:40 +00:00
Zuul
95d35539bc Merge "Set neutron client logging to INFO" 2019-10-12 12:40:39 +00:00
Zuul
72c2527b7b Merge "Add bash script style checker to pep8 check" 2019-10-12 11:20:09 +00:00
Zuul
1876d42970 Merge "Add the Amphora image building guide to the docs" 2019-10-12 09:49:27 +00:00
Brian Haley
5934280e03 Switch to openstack-python3-ussuri-jobs
Octavia was using train jobs template: openstack-python3-train-jobs
but now we are in Ussuri cycle so let's switch to new template.
Modeled after neutron change https://review.opendev.org/#/c/688104/

Change-Id: I824c3ed541cfd42e3c8f02be5da694f42f40d7c2
2019-10-11 13:27:50 -04:00
Jim Rollenhagen
7b8e6de1b8 Clean up requirements.txt from tox.ini
Since the base testenv tox target sets `usedevelop=True`, tox will
install the application (Octavia) into the virtualenv as well. Since
installing Octavia will install everything in requirements.txt, we don't
need to specify it again in tox.ini.

Change-Id: I31bdb2956ae37d1116069c2b37656ce2ee3c2dd5
2019-10-10 18:40:58 -07:00
Brian Haley
65905cdb99 Use bandit block in tox.ini
Use the bandit testenv block in tox.ini instead of inlining
it. Also changed the call back to '-x tests' since that is
correct syntax, it was just broken in version 1.6.0, which
is now in the blacklist.

Change-Id: Id0bf1c6b1633ffb4143c7628b722434faf433d7d
2019-10-10 14:01:40 -04:00
Brian Haley
98448dce44 Add bash script style checker to pep8 check
Added the bashate script style checker to the pep8
check target in tox.ini. It actually found two valid
issues - a bad function declaration and a local variable
issue, but mostly just indentation noise. Fixed all the
complaints.

Change-Id: I43b60e7dcf53acf259c8a52b248fbb8c63d3c8d4
2019-10-10 13:54:58 -04:00
Michael Johnson
d56b9d65c1 Fix log offload file permissions in CentOS devstack
CentOS sets a restrictive umask by default that will override the
rsyslog file permissions settings. This can cause our tempest tests
to no be able to read the log offload files in our CentOS gate jobs.
This patch clears this umask override in the devstack rsyslog
configuration.

Note: This is a global setting for rsyslog and you probably do not
      want to set this outside of a testing environment.

Change-Id: I5962e335acff79152fa49c27c883aef2879593db
2019-10-10 08:37:38 -07:00
Brian Haley
e9b2bcd04e Do not set log format when 'no log' is set
Re-factored code to not insert a log-format line in haproxy
config when 'no log' is set in the template. Adjusted tests
as necessary.

Story: 2006181
Task: 35706

Change-Id: I8a0cdf7ee912d39d9ac24244728094a1d1e15c63
2019-10-10 11:12:55 -04:00
Brian Haley
e6cd43d6cc Remove duplicate keys in sample config files
W0109: Duplicate key 'protocol' in dictionary (duplicate-key)

Trivialfix

Change-Id: Ic194a030edd84106217eb5ac02f9b3190d3a7ba6
2019-10-09 21:19:58 -04:00
Michael Johnson
9be2e4d4d2 Add the Amphora image building guide to the docs
This patch adds the Amphora image building guide from the
diskimage-create README.rst to the Administration documentation.
It also re-organizes the Adminstration guides to be broken down
by category as the old page was becoming a long list of guides.
(I like that kind of problem)
The diskimage-create README has a few formating corrections to make
it render better for the documentation.

Change-Id: Ice4071e1f872c8c0d0595427cff6f02ffbcf7968
2019-10-09 15:33:41 -07:00
Zuul
ca80bc9e03 Merge "Bump diskimage-builder minimum to 2.24.0" 2019-10-09 01:32:49 +00:00
Adam Harwell
b0c2cd7b4c Fix urgent amphora two-way auth security bug
The value of gunicorn's option 'cert_reqs` for client-cert requirement
does not take a boolean, but rather `ssl.CERT_REQUIRED` which is `2`.

Story: 2006660
Task: 36916

SecurityImpact: CVE-2019-17134

Change-Id: I5619f5e40d7c9a2ee7741bf4664c0d2d08963992
2019-10-04 13:14:38 -07:00
Daniel 'f0o' Preussker
d429af5d53 Add Gentoo platform detection in diskimage-create/diskimage-create.sh
Change-Id: Iac685b424d6ab03a23c35c9eef8356f50a2fe952
Task: 36882
Story: 2006646
2019-10-02 10:56:41 +02:00
Zuul
cb214ad13e Merge "Fix healthmonitor message v2 for UDP listeners" 2019-10-01 08:51:55 +00:00
Zuul
dfde453ea7 Merge "Update master for stable/train" 2019-10-01 08:51:52 +00:00
Zuul
8883660c7c Merge "Fix certificate directory creation" 2019-10-01 08:51:50 +00:00
Gregory Thiemonge
c7f4b4a9db Fix certificate directory creation
When calling ./stack.sh twice, octavia devstack plugin fails because
local certificate directory already exists.

This commit deletes the directory each time a certificate creation
script is called and when the user cleans up his devstack's
installation.

Change-Id: I21dfffa9b30274fa0fa9f365a88222b8f4c89e29
2019-09-27 09:40:08 +02:00
61532a0977 Update master for stable/train
Add file to the reno documentation build to show release notes for
stable/train.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/train.

Change-Id: I7240d59e81529cd787a3975cc834208ec5db3deb
Sem-Ver: feature
2019-09-26 19:54:38 +00:00