Optimise the distro package installation

In order to optimise the distro package installation
process the list of packages to install is prepared
for the host, then installed by passing the package
task the full list instead of using a loop.

The package lists in defaults are removed as it is
undesirable to make it easy to override these lists.
This is not provided for in any other roles.

Change-Id: I71307d2a808fdc0f76e376a84651dad86b3f8b69
This commit is contained in:
Jesse Pretorius 2017-06-08 16:50:15 +01:00
parent fb7ba0120a
commit d90f57aca9
3 changed files with 28 additions and 18 deletions

View File

@ -39,6 +39,4 @@ memcached_connections: 1024
memcached_threads: 4
memcached_file_limits: "{{ memcached_connections | int + 1024 }}"
memcached_distro_packages: []
memcached_test_distro_packages: []
install_test_packages: False

View File

@ -13,9 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
- name: Install memcached packages
- name: Install distro packages
package:
name: "{{ item }}"
name: "{{ memcached_package_list }}"
state: "{{ memcached_package_state }}"
update_cache: "{{ (ansible_pkg_mgr == 'apt') | ternary('yes', omit) }}"
cache_valid_time: "{{ (ansible_pkg_mgr == 'apt') | ternary(cache_timeout, omit) }}"
@ -23,17 +23,3 @@
until: install_packages | success
retries: 5
delay: 2
with_items: "{{ memcached_distro_packages }}"
- name: Install memcached packages for testing
package:
name: "{{ item }}"
state: "{{ memcached_package_state }}"
update_cache: "{{ (ansible_pkg_mgr == 'apt') | ternary('yes', omit) }}"
cache_valid_time: "{{ (ansible_pkg_mgr == 'apt') | ternary(cache_timeout, omit) }}"
register: install_test_packages
until: install_test_packages | success
retries: 5
delay: 2
with_items: "{{ memcached_test_distro_packages }}"
when: install_test_packages | bool

26
vars/main.yml Normal file
View File

@ -0,0 +1,26 @@
---
# Copyright 2017, Rackspace US, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Compile a list of the distro packages to install based on
# whether the host is in the host group and the service is
# enabled.
#
memcached_package_list: |-
{% set packages = memcached_distro_packages %}
{% if install_test_packages | bool %}
{% set _ = packages.extend(memcached_test_distro_packages) %}
{% endif %}
{{ packages }}