openstack
/
openstack-ansible-os_barbican
Code Issues Proposed changes

Add qos_prefetch_count to variables 

When rabbit_stream_fanout is set to true, rabbit_qos_prefetch_count
should be set to a positive value.

This also fixes defenition of transient_quorum_queue as if
rabbit_stream_fanout is enabled - transient_quorum_queue should be also
enabled. [1]

[1] https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/impl_rabbit.py#L726-L736

Change-Id: I3b7b501ded69c7d4ef0aa9b89649ad227cf51ed0
This commit is contained in:
Dmitriy Rabotyagov 2024-05-10 18:11:18 +02:00
parent 2f881f8d73
commit c46805fe1a
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
defaults/main.yml
View File

@ -221,9 +221,10 @@ barbican_oslomsg_notify_policies: []
## RabbitMQ integration
barbican_oslomsg_rabbit_quorum_queues: "{{ oslomsg_rabbit_quorum_queues | default(True) }}"
barbican_oslomsg_rabbit_transient_quorum_queues: "{{ oslomsg_rabbit_transient_quorum_queues | default(barbican_oslomsg_rabbit_quorum_queues) }}"
barbican_oslomsg_rabbit_queue_manager: "{{ oslomsg_rabbit_queue_manager | default(barbican_oslomsg_rabbit_quorum_queues) }}"
barbican_oslomsg_rabbit_stream_fanout: "{{ oslomsg_rabbit_stream_fanout | default(barbican_oslomsg_rabbit_quorum_queues) }}"
barbican_oslomsg_rabbit_transient_quorum_queues: "{{ oslomsg_rabbit_transient_quorum_queues | default(barbican_oslomsg_rabbit_stream_fanout) }}"
barbican_oslomsg_rabbit_qos_prefetch_count: "{{ oslomsg_rabbit_qos_prefetch_count | default(barbican_oslomsg_rabbit_stream_fanout | ternary(10, 0)) }}"
barbican_oslomsg_rabbit_queue_manager: "{{ oslomsg_rabbit_queue_manager | default(barbican_oslomsg_rabbit_quorum_queues) }}"
barbican_oslomsg_rabbit_quorum_delivery_limit: "{{ oslomsg_rabbit_quorum_delivery_limit | default(0) }}"
barbican_oslomsg_rabbit_quorum_max_memory_bytes: "{{ oslomsg_rabbit_quorum_max_memory_bytes | default(0) }}"

3
templates/barbican.conf.j2
View File

@ -30,7 +30,8 @@ transport_url = {{ barbican_oslomsg_notify_transport }}://{% for host in barbica
[oslo_messaging_rabbit]
ssl = {{ barbican_oslomsg_notify_use_ssl | bool }}
rabbit_quorum_queue = {{ barbican_oslomsg_rabbit_quorum_queues }}
transient_quorum_queue = {{ barbican_oslomsg_rabbit_transient_quorum_queues }}
rabbit_transient_quorum_queue = {{ barbican_oslomsg_rabbit_transient_quorum_queues }}
rabbit_qos_prefetch_count = {{ barbican_oslomsg_rabbit_qos_prefetch_count }}
use_queue_manager = {{ barbican_oslomsg_rabbit_queue_manager }}
rabbit_stream_fanout = {{ barbican_oslomsg_rabbit_stream_fanout }}
rabbit_quorum_delivery_limit = {{ barbican_oslomsg_rabbit_quorum_delivery_limit }}