Optimise pip install tasks

Unlike the Ansible apt module, the Ansible pip module does not
recognise a with_items list and process all the items at once.

To optimise the pip install tasks, this patch replaces the use
of with_items with a join filter so that the pip install task
does an install with all the packages in a list, ensuring that
the execution is one action instead of many.

Change-Id: I52352809eb61d09772ce628bf759c4340b438125
This commit is contained in:
Jesse Pretorius 2016-07-18 16:10:55 +01:00
parent 986d1d8092
commit 0425d1cf26
1 changed files with 2 additions and 4 deletions

View File

@ -51,14 +51,13 @@
- name: Install required pip packages
pip:
name: "{{ item }}"
name: "{{ keystone_requires_pip_packages | join(' ') }}"
state: latest
extra_args: "{{ pip_install_options_fact }}"
register: install_packages
until: install_packages|success
retries: 5
delay: 2
with_items: "{{ keystone_requires_pip_packages }}"
- name: Get local venv checksum
stat:
@ -125,7 +124,7 @@
- name: Install pip packages
pip:
name: "{{ item }}"
name: "{{ keystone_pip_packages | join(' ') }}"
state: latest
virtualenv: "{{ keystone_bin | dirname }}"
virtualenv_site_packages: "no"
@ -134,7 +133,6 @@
until: install_packages|success
retries: 5
delay: 2
with_items: "{{ keystone_pip_packages }}"
when:
- keystone_get_venv | failed or keystone_developer_mode | bool
notify: