Fix linter errors

Add noqa where requried http://paste.openstack.org/show/798685/

Also remove centos-7 jobs as these are not supported for Victoria and
are blocking further patches merging.
Change-Id: I92f9131daf23f5cd38054a0b7c385344994a2aa0

doc/source/conf.py

@@ -240,7 +240,7 @@ latex_elements = {
 #  author, documentclass [howto, manual, or own class]).
 latex_documents = [
     (master_doc, 'doc-' + target_name + '.tex',
-     title.replace("_", "\_"), author, 'manual'),
+     title.replace("_", r"\_"), author, 'manual'),
 ]
 
 # The name of an image file (relative to this directory) to place at the top of

library/keystone_sp

@@ -18,7 +18,7 @@
 import json
 
 # import module snippets
-from ansible.module_utils.basic import *
+from ansible.module_utils.basic import AnsibleModule
 
 
 DOCUMENTATION = """
@@ -118,5 +118,6 @@ def main():
     except Exception as exp:
         module.fail_json(msg='Failed Process: "%s"' % exp)
 
+
 if __name__ == '__main__':
     main()

tasks/keystone_federation_sp_shib_setup.yml

@@ -29,11 +29,11 @@
 - name: Copy Shibboleth SP key-pair (if provided)
   copy:
     content: "{{ item.content }}"
-    dest: "{{ item.dest }}"
+    dest: "{{ item.dest }}"  # noqa 206
     mode: "{{ item.mode|default('0640') }}"
   when:
     - _keystone_is_first_play_host
-    - item.content != ''
+    - item.content | length > 0
   with_items:
     - { content: "{{ shibboleth_cert_user_content }}", dest: "/etc/shibboleth/sp-cert.pem" }
     - { content: "{{ shibboleth_key_user_content }}", dest: "/etc/shibboleth/sp-key.pem" }

tasks/keystone_idp_self_signed_create.yml

@@ -17,9 +17,8 @@
   file:
     dest: "{{ keystone_idp.cerfile }}"
     state: "absent"
-  when: >
+  when:
-    keystone_idp.regen_cert == true or
+    - keystone_idp.regen_cert | bool
-    keystone_idp.regen_cert == "True"
 
 - name: Create IdP self-signed ssl cert
   command: >

zuul.d/project.yaml

@@ -23,9 +23,7 @@
       - release-notes-jobs-python3
     check:
       jobs:
-        - openstack-ansible-uw_apache-centos-7
         - openstack-ansible-uw_apache-ubuntu-bionic
     gate:
       jobs:
-        - openstack-ansible-uw_apache-centos-7
         - openstack-ansible-uw_apache-ubuntu-bionic