Add boot priorities to containers

This change adds boot priorities to some container types where it'd be
beneficial. LXC allows containers with higher priority values to be
started ahead of others. The container default is 0 and all integers
greater than 0 will be started in descending order.

This change has no upgrade impact as the additional config is only used
on boot and will not require a container to be restarted.

Change-Id: I89703a24516d47d560c9c888538c384ad2228eb7
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

playbooks/common-tasks/os-lxc-container-setup.yml

@@ -81,6 +81,16 @@
   register: _ec
   when: not is_metal | bool
 
+- name: Extra lxc config no restart
+  lineinfile:
+    dest: "/var/lib/lxc/{{ inventory_hostname }}/config"
+    line: "{{ item.split('=')[0] }} = {{ item.split('=', 1)[1] }}"
+    insertafter: "^{{ item.split('=')[0] }}"
+    backup: "true"
+  with_items: "{{ extra_container_config_no_restart | default([]) }}"
+  delegate_to: "{{ physical_host }}"
+  when: not is_metal | bool
+
 # Due to https://github.com/ansible/ansible-modules-extras/issues/2691
 # this uses the LXC CLI tools to ensure that we get logging.
 # TODO(odyssey4me): revisit this once the bug is fixed and released

playbooks/galera-install.yml

@@ -29,6 +29,8 @@
         list_of_bind_mounts:
           - bind_dir_path: "/var/lib/mysql"
             mount_path: "/openstack/{{ inventory_hostname }}"
+        extra_container_config_no_restart:
+          - "lxc.start.order=99"
     - include: common-tasks/package-cache-proxy.yml
   vars:
     is_metal: "{{ properties.is_metal|default(false) }}"

playbooks/os-cinder-install.yml

@@ -51,6 +51,8 @@
           - "lxc.autodev=0"
           - "lxc.cgroup.devices.allow=a *:* rmw"
           - "lxc.mount.entry=udev dev devtmpfs defaults 0 0"
+        extra_container_config_no_restart:
+          - "lxc.start.order=79"
       when:
         - inventory_hostname in groups['cinder_volume']
         - cinder_backend_lvm_inuse | bool

playbooks/os-keystone-install.yml

@@ -20,6 +20,9 @@
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml
+      vars:
+        extra_container_config_no_restart:
+          - "lxc.start.order=89"
     - include: common-tasks/rabbitmq-vhost-user.yml
       static: no
       vars:

playbooks/os-neutron-install.yml

@@ -28,6 +28,8 @@
             mount_path: "/lib/modules"
         extra_container_config:
           - "lxc.cgroup.devices.allow=a *:* rmw"
+        extra_container_config_no_restart:
+          - "lxc.start.order=79"
       when:
         - inventory_hostname in groups['neutron_agent']
         - ansible_pkg_mgr == 'apt'

playbooks/os-nova-install.yml

@@ -20,6 +20,9 @@
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml
+      vars:
+        extra_container_config_no_restart:
+          - "lxc.start.order=69"
     - include: common-tasks/rabbitmq-vhost-user.yml
       static: no
       vars:

playbooks/os-swift-install.yml

@@ -20,6 +20,9 @@
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml
+      vars:
+        extra_container_config_no_restart:
+          - "lxc.start.order=79"
     - include: common-tasks/os-log-dir-setup.yml
       vars:
         log_dirs:

playbooks/rabbitmq-install.yml

@@ -20,6 +20,10 @@
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml
+      static:
+      vars:
+        extra_container_config_no_restart:
+          - "lxc.start.order=99"
     - include: common-tasks/package-cache-proxy.yml
   roles:
     - role: "system_crontab_coordination"

playbooks/rsyslog-install.yml

@@ -24,6 +24,8 @@
         list_of_bind_mounts:
           - bind_dir_path: "{{ rsyslog_server_storage_directory }}"
             mount_path: "/openstack/{{ inventory_hostname }}/log-storage"
+        extra_container_config_no_restart:
+          - "lxc.start.order=99"
     - include: common-tasks/package-cache-proxy.yml
   roles:
     - role: "rsyslog_server"

releasenotes/notes/extra_container_config_no_restart-6e892a95956eff1f.yaml

@@ -0,0 +1,13 @@
+---
+features:
+  - Container boot ordering has been implemented on container types
+    where it would be beneficial. This change ensures that stateful
+    systems running within a container are started ahead of
+    non-stateful systems. While this change has no impact on a running
+    deployment it will assist with faster recovery should any node
+    hosting container go down or simply need to be restarted.
+  - A new task has been added to the "os-lxc-container-setup.yml"
+    common-tasks file. This new task will allow for additional
+    configurations to be added without having to restart the
+    container. This change is helpful in cases where non-impacting
+    config needs to be added or updated to a running containers.