openstack/openstack-ansible
Code Issues Proposed changes

Set PrivateDevices=false for MemcacheD

Browse Source 
This patch sets the `memcached_disable_privatedevices` variable in the
memcached_server role. If memcached is deployed with a container, the
PrivateDevices configuration will be disabled in the systemd unit file.

Change-Id: Idc153c45f5da2ee44b49dbd5ef4577f749550556
Related-Bug: 1697531
This commit is contained in:
Jesse Pretorius 2017-06-15 14:50:44 +01:00 committed by Jesse Pretorius (odyssey4me)
parent 1a35b18b78
commit 14ae2dd534
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
group_vars/memcached.yml
View File

@ -17,3 +17,7 @@ memcached_listen: "{{ ansible_host }}"
# Ensure that the package state matches the global setting # Ensure that the package state matches the global setting
memcached_package_state: "{{ package_state }}" memcached_package_state: "{{ package_state }}"
# Disable PrivateDevices for MemcacheD on CentOS 7
# See https://bugs.launchpad.net/openstack-ansible/+bug/1697531 for details.
memcached_disable_privatedevices: "{{ ((properties.is_metal | default(false)) | bool) | ternary('false', 'true') }}"

14
releasenotes/notes/centos-memcached-privatedevices-d3be3acb19ed71d6.yaml Normal file
View File

@ -0,0 +1,14 @@
---
issues:
- |
OpenStack-Ansible sets a new variable, `memcached_disable_privatedevices`,
that controls whether the `PrivateDevices` configuration in MemcacheD's
systemd unit file is enabled.
If the `memcached_server` role is deployed on a bare metal host, the
default is maintained (`PrivateDevices=true`). If the role is deployed
within a container, the `PrivateDevices` configuration is set to `true`
to work around a systemd bug with a bind mounted `/dev/ptmx`.
See `Launchpad Bug 1697531 <https://bugs.launchpad.net/openstack-ansible/+bug/1697531>`_
for more details.