Disable keepalived ping tests by default

At the moment, the keepalived ping tests are something that is
configured by default which is ideal because it's hardcoded with
a public IP address that might result in a failing deployment
if the environment does not for some reason reach it.

We should leave the option to be there however not have all default
deployments hitting this IP as it can introduce behaviour where
if that IP fails, every single OpenStack Ansible deployment would
fail afterwards.

Closes-Bug: #1672453
Change-Id: I5aec4664e67fb2b3e1c0a2fc9782a4ccaa78a39a

etc/openstack_deploy/openstack_user_config.yml.example

@@ -783,7 +783,6 @@
 # deployment. Refer to the ``user_variables.yml`` file for
 # more information.
 #
-# Keepalived pings a public IP address to check its status. The default
-# address is ``193.0.14.129``. To change this default,
-# set the ``keepalived_ping_address`` variable in the
+# Keepalived cam ping a public IP address to check its status.  To enable this
+# feature, set the ``keepalived_ping_address`` variable in the
 # ``user_variables.yml`` file.

inventory/group_vars/haproxy/keepalived.yml

@@ -13,7 +13,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-keepalived_ping_address: "193.0.14.129"
 keepalived_ping_count: 1
 keepalived_ping_interval: 10
 keepalived_ubuntu_src: "native"

releasenotes/notes/remove-ping-checks-by-default-f86fc237e779b80e.yaml

@@ -0,0 +1,6 @@
+---
+upgrade:
+  - The ping check that happens inside keepalived to make sure that the server
+    that runs it can reach 193.0.14.129 has been removed by default.  The
+    functionality can continue to be used if you define the `keepalived_ping_address`
+    in your `user_variables.yml` file to `193.0.14.129` or any IP of your choice.