Avoid using gather_facts as a variable

Ansible throws a warning when we use gather_facts as a variable. This
patches changes the variable to osa_gather_facts to avoid warnings.

Closes-Bug: 1722604
Change-Id: Ic0a46b93e1ba62bc8e99e2d0a279c361a168690b

playbooks/common-playbooks/cinder.yml

@@ -16,7 +16,7 @@
 - name: Install cinder services
   hosts: "{{ cinder_hosts }}"
   serial: "{{ cinder_serial }}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   tags:

playbooks/common-playbooks/glance.yml

@@ -16,7 +16,7 @@
 - name: Install glance services
   hosts: "{{ glance_hosts }}"
   serial: "{{ glance_serial }}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   tags:

playbooks/common-playbooks/neutron.yml

@@ -16,7 +16,7 @@
 - name: Install neutron services
   hosts: "{{ neutron_hosts }}"
   serial: "{{ neutron_serial }}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   tags:

playbooks/common-playbooks/nova.yml

@@ -16,7 +16,7 @@
 - name: Install nova services
   hosts: "{{ nova_hosts }}"
   serial: "{{ nova_serial }}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"
   vars_files:

playbooks/etcd-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install etcd server cluster
   hosts: etcd_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/galera-install.yml

@@ -15,7 +15,7 @@
 
 - name: Galera container config
   hosts: galera_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   serial: 1
   max_fail_percentage: 0
   user: root
@@ -43,7 +43,7 @@
 
 - name: Install galera server
   hosts: galera_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   serial: 1
   max_fail_percentage: 20
   user: root

playbooks/haproxy-install.yml

@@ -15,7 +15,7 @@
 
 - name: haproxy base config
   hosts: haproxy
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml
@@ -42,7 +42,7 @@
 
 - name: Install haproxy
   hosts: haproxy
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/lxc-containers-create.yml

@@ -15,7 +15,7 @@
 
 - name: Gather lxc container host facts
   hosts: "{{ lxc_host_group | default('lxc_hosts')}}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
 
 - name: Create container(s)
   hosts: "{{ container_group|default('all_containers') }}"

playbooks/lxc-hosts-setup.yml

@@ -15,7 +15,7 @@
 
 - name: Basic lxc host setup
   hosts: "{{ lxc_host_group | default('lxc_hosts')}}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/memcached-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install memcached
   hosts: memcached
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/openstack-hosts-setup.yml

@@ -38,7 +38,7 @@
 
 - name: Basic host setup
   hosts: "{{ openstack_host_group|default('hosts') }}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-aodh-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install the aodh components
   hosts: aodh_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-barbican-install.yml

@@ -15,7 +15,7 @@
 
 - name: Installation and setup of barbican
   hosts: barbican_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-ceilometer-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install the ceilometer components
   hosts: ceilometer_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-designate-install.yml

@@ -18,7 +18,7 @@
 
 - name: Install designate server
   hosts: designate_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml

playbooks/os-heat-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install heat server
   hosts: heat_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-horizon-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install horizon server
   hosts: horizon_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-ironic-install.yml

@@ -15,7 +15,7 @@
 
 - name: Installation and setup of Ironic
   hosts: ironic_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml

playbooks/os-keystone-install.yml

@@ -61,7 +61,7 @@
 - name: Installation and setup of Keystone
   hosts: keystone_all
   serial: "{{ keystone_serial | default(['1', '100%']) }}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   environment: "{{ deployment_environment_variables | default({}) }}"

playbooks/os-molteniron-install.yml

@@ -15,7 +15,7 @@
 
 - name: Installation and setup of molteniron
   hosts: molteniron_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml

playbooks/os-octavia-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install octavia server
   hosts: octavia_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-rally-install.yml

@@ -15,7 +15,7 @@
 
 - name: Installation and setup of Rally
   hosts: utility_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/unbound-clients.yml

playbooks/os-sahara-install.yml

@@ -13,7 +13,7 @@
 
 - name: Install sahara server
   hosts: sahara_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml

playbooks/os-swift-install.yml

@@ -15,7 +15,7 @@
 
 - name: Installation and setup of Swift
   hosts: swift_all:swift_remote_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-swift-sync.yml

@@ -17,7 +17,7 @@
 # The services need to be installed first though.
 - name: Synchronisation of swift ring and ssh keys
   hosts: swift_all:swift_remote_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   roles:

playbooks/os-tacker-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install the tacker components
   hosts: tacker_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/os-tempest-install.yml

@@ -15,7 +15,7 @@
 
 - name: Installation and setup of Tempest
   hosts: utility_all[0]
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   roles:

playbooks/os-trove-install.yml

@@ -18,7 +18,7 @@
 
 - name: Install trove server
   hosts: trove_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/os-lxc-container-setup.yml

playbooks/rabbitmq-install.yml

@@ -16,7 +16,7 @@
 - name: Create and configure rabbitmq container
   hosts: "{{ rabbitmq_host_group | default('rabbitmq_all') }}"
   serial: 1
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 0
   user: root
   pre_tasks:

playbooks/repo-build.yml

@@ -44,7 +44,7 @@
 
 - name: Build new repo packages for a given release
   hosts: repo_masters
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   any_errors_fatal: true
   user: root
   serial: 1

playbooks/repo-server.yml

@@ -15,7 +15,7 @@
 
 - name: Setup repo servers
   hosts: repo_all
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/rsyslog-install.yml

@@ -15,7 +15,7 @@
 
 - name: Install rsyslog
   hosts: rsyslog
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   max_fail_percentage: 20
   user: root
   pre_tasks:

playbooks/security-hardening.yml

@@ -19,7 +19,7 @@
 
 - name: Apply security hardening configurations
   hosts: "{{ security_host_group|default('hosts') }}"
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   roles:
     - role: "ansible-hardening"

playbooks/unbound-install.yml

@@ -16,7 +16,7 @@
 - name: Install unbound DNS resolvers
   hosts:
     - unbound
-  gather_facts: "{{ gather_facts | default(True) }}"
+  gather_facts: "{{ osa_gather_facts | default(True) }}"
   user: root
   pre_tasks:
     - include: common-tasks/os-log-dir-setup.yml

scripts/gate-check-commit.sh

@@ -173,7 +173,7 @@ pushd "${OSA_CLONE_DIR}/playbooks"
 
   # Prepare the hosts
   export ANSIBLE_LOG_PATH="${ANSIBLE_LOG_DIR}/setup-hosts.log"
-  openstack-ansible setup-hosts.yml -e gather_facts=False
+  openstack-ansible setup-hosts.yml -e osa_gather_facts=False
 
   # Log some data about the instance and the rest of the system
   log_instance_info
@@ -185,14 +185,14 @@ pushd "${OSA_CLONE_DIR}/playbooks"
 
   # Prepare the infrastructure
   export ANSIBLE_LOG_PATH="${ANSIBLE_LOG_DIR}/setup-infrastructure.log"
-  openstack-ansible setup-infrastructure.yml -e gather_facts=False
+  openstack-ansible setup-infrastructure.yml -e osa_gather_facts=False
 
   # Log some data about the instance and the rest of the system
   log_instance_info
 
   # Setup OpenStack
   export ANSIBLE_LOG_PATH="${ANSIBLE_LOG_DIR}/setup-openstack.log"
-  openstack-ansible setup-openstack.yml -e gather_facts=False
+  openstack-ansible setup-openstack.yml -e osa_gather_facts=False
 
   # Log some data about the instance and the rest of the system
   log_instance_info