openstack/openstack-ansible
Code Issues Proposed changes

Set default pass in aio scripts to be random

Browse Source 
In the bootstrap-aio.sh and osad-aio-heat-template.yml we use a default
password of "secrete". As a minor security concern, this patch adjusts
this to be random.

Change-Id: I54b9a085aba7845b7a9ad435c60604359921fc09
Closes-Bug: #1462000
This commit is contained in:
Andy McCrae 2015-06-10 18:05:33 +01:00 committed by Jesse Pretorius
parent ad022e0a1d
commit 888f0ec87a
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/bootstrap-aio.sh
View File

@ -19,7 +19,8 @@ set -e -u -x
## Vars ---------------------------------------------------------------------- ## Vars ----------------------------------------------------------------------
export ADMIN_PASSWORD=${ADMIN_PASSWORD:-"secrete"} DEFAULT_PASSWORD=$(head -c 64 /dev/urandom | tr -dc 'a-zA-Z0-9')
export ADMIN_PASSWORD=${ADMIN_PASSWORD:-$DEFAULT_PASSWORD}
export SERVICE_REGION=${SERVICE_REGION:-"RegionOne"} export SERVICE_REGION=${SERVICE_REGION:-"RegionOne"}
export DEPLOY_SWIFT=${DEPLOY_SWIFT:-"yes"} export DEPLOY_SWIFT=${DEPLOY_SWIFT:-"yes"}
export GET_PIP_URL=${GET_PIP_URL:-"https://bootstrap.pypa.io/get-pip.py"} export GET_PIP_URL=${GET_PIP_URL:-"https://bootstrap.pypa.io/get-pip.py"}

4
scripts/osad-aio-heat-template.yml
View File

@ -56,8 +56,10 @@ outputs:
value: { get_attr: [ OSADAIO, first_address ] } value: { get_attr: [ OSADAIO, first_address ] }
OSADAIO_password: OSADAIO_password:
description: The password for all the things. description: The password for all the things.
value: secrete value: { get_attr: [ OSADAIO_random_pass, value ] }
resources: resources:
OSADAIO_random_pass:
type: OS::Heat::RandomString
OSADAIO_port: OSADAIO_port:
type: OS::Neutron::Port type: OS::Neutron::Port
properties: properties: