Fixes RabbitMQ guest user creation

This change removes the "guest" user. This patch fixes an issues
where the guest user was not being cared by default which could
leave a deployment vulnerable to should someone gain access to the
internal network that the messaging system runs within. To fix this
issue the guest user is simply being removed as its not needed by the
rest of the stack.

Closes-Bug: #1466982
Change-Id: I81f9295daf7923b828ad884b6707bb3f74b0684a

playbooks/roles/rabbitmq_server/tasks/rabbitmq_post_install.yml

@@ -57,3 +57,24 @@
     state: "present"
   tags:
     - rabbitmq-user
+
+# This is being done because the rabbitctl command used by the module
+# is not very effective at returning proper status codes for failure
+# and the module does not error detection. until we can go upstream
+# to fix this issue this task being being done in two parts to ensure
+# that the "guest" user is eradicated.
+- name: Ensure default rabbitmq guest user is removed
+  rabbitmq_user:
+    user: guest
+    state: absent
+  when: inventory_hostname == groups['rabbitmq_all'][0]
+  tags:
+    - rabbitmq-user
+
+- name: Ensure default rabbitmq guest user is removed
+  rabbitmq_user:
+    user: guest
+    state: absent
+  when: inventory_hostname != groups['rabbitmq_all'][0]
+  tags:
+    - rabbitmq-user