Fix issues with infrastructure healthcheck

1. If the load balancer host is not the same as the control
   plane hosts, then 'Ensuring haproxy runs' fails unless
   facts are gathered.

2. The value for 'repo_release_path' is set in the vars file
   'defaults/source_install.yml', so the repo check fails
   without reference to that vars file.

3. When running 'Sanity checks for all containers' not all
   host and container facts are gathered, so the play fails
   due to missing facts unless facts are set to gather.

4. Instead of verifying both localhost and the utility
   containers for being ready to run the os_* modules, we
   only need to verify whichever one is the designated
   'openstack_service_setup_host'.

5. The memcache server connectivity test should have a short
   timeout, otherwise the task hangs for ages if it isn't
   working.

6. The rabbitmq vhost name is corrected and set consistently,
   otherwise those tests do not work.

7. The rabbitmq test venv fails to build for two reasons. One
   is that the venv creation fails, because virtualenv tries
   to download the latest pip/setuptools and fails due to the
   pip.conf restricting it. The second is that the python
   package 'pika' is not on the repo server. The task is changed
   to make use of the common python_venv_build role and to make
   use of pypi as an index when building the wheel.

Change-Id: I6f5f4a1bd55abc78ad5993076719a3ac5914af1d

playbooks/healthcheck-infrastructure.yml

@@ -38,7 +38,7 @@
 # Test haproxy-install.yml
 - name: Ensuring haproxy runs
   hosts: haproxy
-  gather_facts: no
+  gather_facts: yes
   tasks:
     - name: Check if host can connect to keepalived ping IP
       command: "ping -c 2 {{ keepalived_ping_address }}"
@@ -75,6 +75,8 @@
   serial:
     - 3
     - 100%
+  vars_files:
+    - defaults/source_install.yml
   tasks:
     # Repo release path points to the internal LB vip
     - name: Check the presence of upper constraints on your repos and check load balancing
@@ -86,7 +88,7 @@
 
 - name: Sanity checks for all containers
   hosts: all_containers:physical_hosts
-  gather_facts: no
+  gather_facts: yes
   tasks:
     - name: Ensure everyone can reach apt proxy
       uri:
@@ -99,8 +101,8 @@
     - healthcheck-repo-use
 
 # Test utility-install.yml
-- name: Ensure utility and localhost are ready to run openstack calls
-  hosts: utility_all:localhost
+- name: Ensure the service setup host is ready to run openstack calls
+  hosts: "{{ openstack_service_setup_host | default('localhost') }}"
   gather_facts: no
   tasks:
     - name: Get openstack client config
@@ -129,7 +131,7 @@
         state: present
 
     - name: Connect to remote memcache servers (full mesh testing)
-      shell:  "echo stats | nc {{ hostvars[memcached_host]['container_address'] }} {{ memcached_port }}"
+      shell:  "echo stats | nc -w 3 {{ hostvars[memcached_host]['container_address'] }} {{ memcached_port }}"
       changed_when: false
       register: memcache_stats
       with_items: "{{ groups['memcached'] }}"
@@ -165,14 +167,14 @@
   tasks:
     - name: Configure Rabbitmq vhost
       rabbitmq_vhost:
-        name: "testvhost"
+        name: "/testvhost"
         state: "present"
 
     - name: Configure Rabbitmq user
       rabbitmq_user:
         user: "testguest"
         password: "secrete"
-        vhost: "testvhost"
+        vhost: "/testvhost"
         configure_priv: ".*"
         read_priv: ".*"
         write_priv: ".*"
@@ -190,9 +192,17 @@
     venv_path: /tmp/rabbitmqtest
   post_tasks:
     - name: Generate venv for rabbitmq testing
-      pip:
-        name: pika
-        virtualenv: "{{ venv_path }}"
+      include_role:
+        name: "python_venv_build"
+        private: yes
+      vars:
+        venv_install_destination_path: "{{ venv_path }}"
+        venv_pip_packages:
+          - pika
+        venv_build_host_wheel_path: "{{ repo_pypiserver_package_path | default('/var/www/repo/pools') }}"
+        venv_pip_install_args: >-
+          --index-url {{ repo_build_pip_default_index | default('https://pypi.python.org/simple') }}
+          --trusted-host {{ (repo_build_pip_default_index | default('https://pypi.python.org/simple')) | netloc_no_port }}
     - name: Copying test script
       copy:
         src: "../scripts/rabbitmq-test.py"
@@ -215,9 +225,9 @@
         vhost: "/testvhost"
         state: absent
       no_log: true
-    - name: Configure Rabbitmq vhost
+    - name: Remove test vhost
       rabbitmq_vhost:
-        name: "testvhost"
+        name: "/testvhost"
         state: "absent"
   tags:
     - healthcheck

scripts/rabbitmq-test.py

@@ -30,7 +30,7 @@ def rabbitmq_connect(ip=None):
     """Connects to ip using standard port and credentials."""
     credentials = pika.credentials.PlainCredentials('testguest', 'secrete')
     parameters = pika.ConnectionParameters(
-        host=ip, virtual_host='/test', credentials=credentials)
+        host=ip, virtual_host='/testvhost', credentials=credentials)
     try:
         connection = pika.BlockingConnection(parameters)
         connection.channel()