openstack/openstack-ansible
Code Issues Proposed changes

Set timeouts on uri tasks

Browse Source 
uri task has a 30 second timeout by default, and in a greenfield
or new host deploy these tasks are always expected to fail, so the
timeout is expected to be met multiple times.

We should set a small timeout on these tasks to fail quickly.

Change-Id: I6748bbd894585d97cce235e854afbcf9d433d34d
This commit is contained in:
Logan V 2018-03-02 11:36:33 +00:00
parent d18a991c48
commit dc5c38331c
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
playbooks/common-tasks/set-pip-upstream-url.yml
View File

@ -21,6 +21,7 @@
uri: uri:
url: "{{ pip_upstream_url }}" url: "{{ pip_upstream_url }}"
method: "HEAD" method: "HEAD"
timeout: 3
register: _repo_data_check register: _repo_data_check
failed_when: false failed_when: false
when: pip_upstream_url != "https://bootstrap.pypa.io/get-pip.py" when: pip_upstream_url != "https://bootstrap.pypa.io/get-pip.py"

2
playbooks/common-tasks/set-upper-constraints.yml
View File

@ -22,6 +22,7 @@
uri: uri:
url: "{{ pip_install_upper_constraints }}" url: "{{ pip_install_upper_constraints }}"
method: "HEAD" method: "HEAD"
timeout: 3
register: upper_constraints_check register: upper_constraints_check
failed_when: false failed_when: false
tags: tags:
@ -31,6 +32,7 @@
uri: uri:
url: "{{ pip_default_index }}" url: "{{ pip_default_index }}"
method: "HEAD" method: "HEAD"
timeout: 3
register: pip_default_index_check register: pip_default_index_check
failed_when: false failed_when: false
tags: tags: