f32a31d585
Existing rsync stop/start handlers were relying on the pattern parameter to the Ansible service module which relies on the results of ps to determine if the service is running. This is unnecessary because the rsync service script is well-behaved and responds appropriately to start stop and restart commands. Removal of the pattern param ensures that the response from the service command is used instead. Root cause of the bug is that when Keystone was changed to share fernet secrets via rsync over ssh tunnel, an rsync process was introduced in AIOs, Swift stand-alones, and other deployment configurations that contain Keystone containers on the storage hosts. The resulting rsync processes within Keystone containers pollute the results of ps commands on the host, fooling Ansible into thinking that an rsync service is running on the standard port when it is not. Secondly, the handler responsible for stopping rsync was not causing the notice for "Ensure rsync service running" to trigger cleanly in my testing, so the tasks were changed to trigger both notices in an ordered list. Change-Id: I5ed47f7c1974d6b22eeb2ff5816ee6fa30ee9309 Closes-Bug: 1481121
80 lines
2.0 KiB
YAML
80 lines
2.0 KiB
YAML
---
|
|
# Copyright 2014, Rackspace US, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
- name: Restart swift account services
|
|
service:
|
|
name: "{{ item }}"
|
|
state: "restarted"
|
|
pattern: "{{ item }}"
|
|
register: service_restart
|
|
with_items: swift_account_program_names
|
|
failed_when: false
|
|
|
|
- name: Restart swift container services
|
|
service:
|
|
name: "{{ item }}"
|
|
state: "restarted"
|
|
pattern: "{{ item }}"
|
|
register: service_restart
|
|
with_items: swift_container_program_names
|
|
failed_when: false
|
|
|
|
- name: Restart swift object services
|
|
service:
|
|
name: "{{ item }}"
|
|
state: "restarted"
|
|
pattern: "{{ item }}"
|
|
register: service_restart
|
|
with_items: swift_object_program_names
|
|
failed_when: false
|
|
|
|
- name: Restart swift proxy services
|
|
service:
|
|
name: "{{ item }}"
|
|
state: "restarted"
|
|
pattern: "{{ item }}"
|
|
register: service_restart
|
|
with_items: swift_proxy_program_names
|
|
failed_when: false
|
|
|
|
- name: Restart service
|
|
service:
|
|
name: "{{ item }}"
|
|
state: "restarted"
|
|
pattern: "{{ item }}"
|
|
enabled: "yes"
|
|
when: item is defined
|
|
|
|
- name: Restart rsyslog
|
|
service:
|
|
name: "rsyslog"
|
|
state: "restarted"
|
|
|
|
- name: Ensure rsync service stopped
|
|
service:
|
|
name: "rsync"
|
|
state: "stopped"
|
|
register: service_restart
|
|
failed_when: "'msg' in service_restart and 'FAIL' in service_restart.msg|upper"
|
|
register: service_restart
|
|
until: add_service|success
|
|
retries: 3
|
|
delay: 2
|
|
|
|
- name: Ensure rsync service running
|
|
service:
|
|
name: "rsync"
|
|
state: "started"
|