3e84d1e36d
This option can cause silent failures which are confusing and hard to
track down. While the intention of this was to allow large scale
deployments to succeed in cases where a single node fails due to
transiant issues it has produced more problems in terms of confusion
that it solves. This change removes the option from all production
playbooks.
Change-Id: I1dcbbf5bc8cc66f11dd8ddc22d2a177c5c0f31f1
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
(cherry picked from commit c2743f5cca)
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
22 lines
1.4 KiB
YAML
22 lines
1.4 KiB
YAML
---
|
|
other:
|
|
- The `max_fail_percentage` playbook option has been used with the default
|
|
playbooks since the first release of the playbooks back in **Icehouse**.
|
|
While the intention was to allow large-scale deployments to succeed in
|
|
cases where a single node fails due to transient issues, this option has
|
|
produced more problems that it solves. If a failure occurs that is transient
|
|
in nature but is under the set failure percentage the playbook will report a
|
|
success, which can cause silent failures depending on where the failure
|
|
happened. If a deployer finds themselves in this situation the problems are
|
|
are then compounded because the tools will report there are no known issues.
|
|
To ensure deployers have the best deployment experience and the most
|
|
accurate information a change has been made to remove the
|
|
`max_fail_percentage` option from all of the default playbooks. The removal
|
|
of this option has the side effect of requiring the deploy to skip specific
|
|
hosts should one need to be omitted from a run, but has the benefit of
|
|
eliminating silent, hard to track down, failures. To skip a failing host
|
|
for a given playbook run use the `--limit '!$HOSTNAME'` CLI switch for the
|
|
specific run. Once the issues have been resolved for the failing host rerun
|
|
the specific playbook without the `--limit` option to ensure everything
|
|
is in sync.
|