cc7bd498fa
USED_IPS being a list did not convey it's intention of limiting IP addresses to only one instance. Using the set data type does this, and removes the need for iterating over the USED_IP array from our own code. Other lists within the code that use the 'append_if' function were not changed here because the set datatype does not get written as a list in YAML, which may be undesirable. It may be completely possible to cast sets as lists on output, but this patch is largely about clarifying intent around USED_IPS so the set-to-list dump logic wasn't explored. Also, the duplicate IP tests were left in place due to the fact that the IP addresses are populated into a queue structure separately, which may still have bugs that don't belong to Python or netaddr. In the future, it may be desirable to modify the IP-handling logic to completely use netaddr's specialized classes. Change-Id: I22312321738d1f1001984d4c81f7fd24b7a1f1c8 |
||
---|---|---|
doc | ||
etc | ||
playbooks | ||
releasenotes | ||
scripts | ||
tests | ||
.gitignore | ||
.gitreview | ||
ansible-role-requirements.yml | ||
ansible-role-requirements.yml.example | ||
global-requirement-pins.txt | ||
LICENSE.txt | ||
README.rst | ||
requirements.txt | ||
setup.cfg | ||
setup.py | ||
test-requirements.txt | ||
tox.ini |
OpenStack-Ansible
OpenStack-Ansible is an official OpenStack project which aims to deploy production environments from source in a way that makes it scalable while also being simple to operate, upgrade, and grow.
For an overview of the mission, repositories and related Wiki home page, please see the formal Home Page for the project.
For those looking to test OpenStack-Ansible using an All-In-One (AIO) build, please see the Quick Start guide.
For more detailed Installation and Operator documentation, please see the Install Guide.
If OpenStack-Ansible is missing something you'd like to see included, then we encourage you to see the Developer Documentation for more details on how you can get involved.
Developers wishing to work on the OpenStack-Ansible project should always base their work on the latest code, available from the master GIT repository at Source.
If you have some questions, or would like some assistance with
achieving your goals, then please feel free to reach out to us on the OpenStack Mailing Lists
(particularly openstack-operators or openstack-dev) or on IRC in
#openstack-ansible
on the freenode network.