openstack/openstack
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update ovsdbapp from branch 'master'
  to eb8a07aacf2eeff9c91397d208a9c964cec8b4e6
  - Use log.warning() from the logging library
    
    Every time I run a large chunk of neutron unit tests, for
    example:
    
    $ tox -e py310 -- neutron.tests.unit.plugins.ml2.drivers
    
    I see this warning (it doesn't cause a failure):
    
    Captured stderr:
    ~~~~~~~~~~~~~~~~
        .../neutron/.tox/py310/lib/python3.10/site-packages/ovs/db/idl.py:1484:
      DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
        vlog.warn("error parsing column %s in table %s: %s"
    
    Looking at the OVS python library code it seems perfectly fine.
    
    Backtracking, I was able to find the offending code that
    actually lived in ovsdbapp. It is a little bit obfuscated
    as it was re-mapping the OVS library vlog.Vlog.warn() call
    to log.warn(), but I was able to test my theory by modifying
    code in my local neutron .tox directory and the warning
    went away.
    
    I was never able to narrow things down to a single test, or
    class, or file, even running with '--concurrency 1', so I
    do not know exactly how this code is getting exercised,
    there could be a test that is not cleaning-up properly,
    maybe some day we will figure that out.
    
    TrivialFix but not TrivialToFind
    
    Change-Id: Ic6256b4bab48298fe599b7904e9edb0e35b93ce4
This commit is contained in:
Brian Haley
2024-05-28 05:20:16 -04:00
committed by Gerrit Code Review
parent e2678eb448
commit 323ca09710
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files