openstack/openstack
Code Issues Proposed changes

Update git submodules

Browse Source 
* Update oslo.messaging from branch 'master'
  - Merge "Cancel consumer if queue down"
  - Cancel consumer if queue down
    
    Previously, we have switched to use default exchanges
    to avoid excessive amounts of exchange not found messages.
    But it does not actually solve the problem because
    reply_* queue is already gone and agent will not receive callbacks.
    
    after some debugging, I found under some circumstances
    seems rabbitmq consumer does not receive basic cancel
    signal when queue is already gone. This might due to
    rabbitmq try to restart consumer when queue is down
    (for example when split brain). In such cases,
    it might be better to fail early.
    
    by reading the code, seems like x-cancel-on-ha-failover
    is not dedicated to mirror queues only, https://github.com/rabbitmq/rabbitmq-server/blob/master/src/rabbit_channel.erl#L1894,
    https://github.com/rabbitmq/rabbitmq-server/blob/master/src/rabbit_channel.erl#L1926.
    
    By failing early, in my own test setup,
    I could solve a certain case of exchange not found problem.
    
    Change-Id: I2ae53340783e4044dab58035bc0992dc08145b53
    Related-bug: #1789177
This commit is contained in:
Zuul
2020-08-01 01:21:42 +00:00
committed by Gerrit Code Review
parent daad2c3cd3
commit 40f3fcabc6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files