df4129a87e
* Update tripleo-upgrade from branch 'master'
to 2766cfa91b9ec515c0eb78cea6cb7649fcf45397
- Fix merge-new-params-nic-config-script.py: error: argument -n/--network-data: expected one argument
In change I50426d2cc296e237fa8a8cf6c750e760b0992dd2 we added:
-n {{ network_data_file | default(default_network_data) }}
The problem is that network_data_file is a fact that is set to ''
whenever there is no -n in the overcloud deploy script. So all
FFUs that deployed without -n now are failing with:
/usr/share/openstack-tripleo-heat-templates/tools/merge-new-params-nic-config-script.py
-n --tht-dir /usr/share/openstack-tripleo-heat-templates --role-name $NIC_ROLE_NAME
--roles-data /home/stack/composable_roles/roles/roles_data.yaml --discard-comments yes
--template /home/stack/composable_roles/network/nic-configs//controller.yaml
merge-new-params-nic-config-script.py: error: argument
-n/--network-data: expected one argument
This is because the empty string is not undefined, so we need to
add a second param to default() set to true:
https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#providing-default-values
Change-Id: Id41ccf25eb96e4307eddb80ef82dbda98f347c0b
OpenStack
OpenStack is a collection of interoperable components that can be deployed to provide computing, networking and storage resources. Those infrastructure resources can then be accessed by end users through programmable APIs.
This repository just represents OpenStack as a collection of git submodules. You can find the repositories for individual components at: https://opendev.org/openstack
You can learn more about the various components in OpenStack at: https://openstack.org/software
To learn more about how to contribute to OpenStack, please head to our Contributor portal: https://www.openstack.org/community/
To learn more about how OpenStack is governed, you can visit: https://governance.openstack.org/
Why this repository ?
Our continuous integration system, Zuul, gates all of the contained projects in an effective single timeline. This means that OpenStack, across all of the projects, does already have a sequence of combinations that have been explicitly tested, but it's non-trivial to go from a single commit of a particular project to the commits that were tested with it.
Gerrit's submodule tracking feature will update a super project every time a subproject is updated, so the specific sequence created by zuul will be captured by the super project commits.
This repo is intended to be used in a read-only manner. Any commit in this repo will get a collection of commits in the other repos that have explicitly been tested with each other, if that sort of thing is important to you.