openstack/openstackclient
Code Issues Proposed changes

Dump check_osc_commands output as yaml

Browse Source 
This is a lot easier to read than what we were doing before.

Change-Id: I30dbd72ef64793ce0451081e6d5bbd7ca547673e
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane
2025-12-18 11:55:42 +00:00
parent 82a809d5ed
commit c1ce4acf70
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test-requirements.txt
View File

@@ -1,2 +1,3 @@
oslotest>=3.2.0 # Apache-2.0
PyYAML>=6.0.0 # MIT
stestr>=2.0.0 # Apache-2.0

19
tests/check_osc_commands.py
View File

@@ -20,6 +20,8 @@ with the purpose of detecting duplicate commands.
import importlib.metadata
import traceback
import yaml
from openstackclient import shell
@@ -107,28 +109,29 @@ def find_duplicates():
duplicate_cmds.setdefault(ep_name, []).append(ep.group)
if duplicate_cmds:
print("Duplicate commands found...")
print("Duplicate commands found...\n")
print(duplicate_cmds)
return True
if failed_cmds:
print("Some commands failed to load...")
print("Some commands failed to load...\n")
print(failed_cmds)
return True
overlap_cmds = _check_command_overlap(valid_cmds)
if overlap_cmds:
print("WARNING: Some commands overlap...")
print(overlap_cmds)
print("WARNING: Some commands overlap...\n")
print(yaml.dump(overlap_cmds))
print()
# FIXME(stevemar): when we determine why commands are overlapping
# we can uncomment the line below.
# return True
# Safely return False here with the full set of commands
print("Final set of commands...")
print(valid_cmds)
print("Ignored commands...")
print(ignored_cmds)
print("Final set of commands...\n")
print(yaml.dump(valid_cmds))
print("Ignored commands...\n")
print(yaml.dump(ignored_cmds))
print("Found no duplicate or overlapping commands, OK to merge!")
return False