openstack/openstackdocstheme
Code Issues Proposed changes

trivial: Remove use of 'Application.{warn,info}'

Browse Source 
These are deprecated since Sphinx 1.6 [1].

http://www.sphinx-doc.org/en/1.6.6/extdev/appapi.html#producing-messages-logging

Change-Id: I3ea89437e5521fa5f1bc3b0382e2b7e6c983b104
This commit is contained in:
Stephen Finucane 2018-01-09 13:56:19 +00:00
parent f0744a1675
commit 0ba64b09e9
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openstackdocstheme/__init__.py
View File

@ -16,9 +16,11 @@ import os
import subprocess import subprocess
import dulwich.repo import dulwich.repo
from sphinx.util import logging
_giturl = 'https://git.openstack.org/cgit/{}/tree/doc/source' _giturl = 'https://git.openstack.org/cgit/{}/tree/doc/source'
_html_context_data = None _html_context_data = None
logger = logging.getLogger(__name__)
def _get_other_versions(app): def _get_other_versions(app):
@ -65,7 +67,7 @@ def _get_other_versions(app):
def builder_inited(app): def builder_inited(app):
theme_dir = os.path.join(os.path.dirname(__file__), 'theme') theme_dir = os.path.join(os.path.dirname(__file__), 'theme')
app.info('Using openstackdocstheme Sphinx theme from %s' % theme_dir) logger.info('Using openstackdocstheme Sphinx theme from %s' % theme_dir)
def get_pkg_path(): def get_pkg_path():
@ -98,7 +100,7 @@ def _html_page_context(app, pagename, templatename, context, doctree):
['git', 'rev-parse', 'HEAD'], ['git', 'rev-parse', 'HEAD'],
).decode('utf-8').strip() ).decode('utf-8').strip()
except Exception: except Exception:
app.warn('Cannot get gitsha from git repository.') logger.warn('Cannot get gitsha from git repository.')
_html_context_data['gitsha'] = 'unknown' _html_context_data['gitsha'] = 'unknown'
giturl = app.config.giturl giturl = app.config.giturl
@ -121,7 +123,7 @@ def _html_page_context(app, pagename, templatename, context, doctree):
def setup(app): def setup(app):
app.info('connecting events for openstackdocstheme') logger.info('connecting events for openstackdocstheme')
app.connect('builder-inited', builder_inited) app.connect('builder-inited', builder_inited)
app.connect('html-page-context', _html_page_context) app.connect('html-page-context', _html_page_context)
app.add_config_value('repository_name', '', 'env') app.add_config_value('repository_name', '', 'env')