openstack/openstackdocstheme
Code Issues Proposed changes

Fix a logic issue in the JS

Browse Source 
When I updated the icon selector as part of
https://review.openstack.org/#/c/485290, I made an error in the logic
meaning that the icons appear next to only the first of each item.
This was part of an initial proposed solution, but isn't actually needed,
and causes multiple usages of versionadded etc to not have icons.

Change-Id: If1c1011d8a7ed1e78f2675eca7daf4e497a8bf9e
This commit is contained in:
Rob Cresswell 2017-07-26 12:40:35 +01:00
parent b0d9ede2b7
commit 979785c760
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/source/demo/index.rst
View File

@ -130,14 +130,24 @@ Configuration addition and deprecation notices
.. versionadded:: 9.0.0-Mitaka
.. versionadded:: 10.0.0-Newton
.. versionchanged:: 10.0.0-Newton
Added support for new tags!
.. versionchanged:: 11.0.0-Ocata
Showing that multiple notices work!
.. deprecated:: 11.0.0-Ocata
Use `Notices`_ instead.
.. deprecated:: 12.0.0-Pike
A second deprecation notice
.. toctree::
:maxdepth: 1

6
openstackdocstheme/theme/openstackdocs/static/js/docs.js
View File

@ -86,9 +86,9 @@ $('div.important > p.admonition-title').prepend('<div class="fa fa-fw fa-check-c
$('div.note > p.admonition-title').prepend('<div class="fa fa-fw fa-check-circle">&nbsp;</div>');
$('div.seealso > p.admonition-title').prepend('<div class="fa fa-fw fa-info-circle">&nbsp;</div>');
$('div.warning > p.admonition-title').prepend('<div class="fa fa-fw fa-exclamation-triangle">&nbsp;</div>');
$('div.versionadded > p').first().prepend('<div class="fa fa-fw fa-plus-circle">&nbsp;</div>');
$('div.versionchanged > p').first().prepend('<div class="fa fa-fw fa-info-circle">&nbsp;</div>');
$('div.deprecated > p').first().prepend('<div class="fa fa-fw fa-minus-circle">&nbsp;</div>');
$('div.versionadded > p').prepend('<div class="fa fa-fw fa-plus-circle">&nbsp;</div>');
$('div.versionchanged > p').prepend('<div class="fa fa-fw fa-info-circle">&nbsp;</div>');
$('div.deprecated > p').prepend('<div class="fa fa-fw fa-minus-circle">&nbsp;</div>');
/* BB 150310
We also insert a space between the icon and the admonition title