openstack
/
os-brick
Code Issues Proposed changes

Merge "encryptors: Deprecate the CryptsetupEncryptor"

This commit is contained in:
Zuul 2019-08-28 20:06:32 +00:00 committed by Gerrit Code Review
parent b7c40aa39b b3e5aa3761
commit dd2cb55788
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
os_brick/encryptors/cryptsetup.py
View File

@ -22,6 +22,7 @@ from os_brick.encryptors import base
from os_brick import exception from os_brick import exception
from oslo_concurrency import processutils from oslo_concurrency import processutils
from oslo_log import log as logging from oslo_log import log as logging
from oslo_log import versionutils
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
@ -146,6 +147,15 @@ class CryptsetupEncryptor(base.VolumeEncryptor):
instance is unaware of the underlying encryption due to modifying the instance is unaware of the underlying encryption due to modifying the
original symbolic link to refer to the device mounted by dm-crypt. original symbolic link to refer to the device mounted by dm-crypt.
""" """
# TODO(lyarwood): Remove this encryptor and refactor the LUKS based
# encryptors in the U release.
versionutils.report_deprecated_feature(
LOG,
"The plain CryptsetupEncryptor is deprecated and will be removed "
"in a future release. Existing users are encouraged to retype "
"any existing volumes using this encryptor to the 'luks' "
"LuksEncryptor or 'luks2' Luks2Encryptor encryptors as soon as "
"possible.")
key = self._get_key(context).get_encoded() key = self._get_key(context).get_encoded()
passphrase = self._get_passphrase(key) passphrase = self._get_passphrase(key)

7
releasenotes/notes/deprecate-plain-cryptsetup-encryptor-0a279abc0b0d718c.yaml Normal file
View File

@ -0,0 +1,7 @@
---
deprecations:
- |
The plain CryptsetupEncryptor is deprecated and will be removed in a future
release. Existing users are encouraged to retype any existing volumes using
this encryptor to the luks LuksEncryptor or luks2 Luks2Encryptor encryptors
as soon as possible