0ff2c0086c
Initially Ic155bd29d46059832cce970bf60375e7e472eca6 had aimed to remove these legacy provider names during the Pike cycle. While removing references to these names in Tempest via Id221414d74af8413084c7935b762f93b7ce43c42 it was highlighted that this wouldn't be possible until Queens and the eventual EOL of Newton. This change simply updates the logged deprecation warnings and adds a new releasenote highlighting that these legancy provider names will remain until Queens. Change-Id: Ib8ca7ecb5494cd4fcae0657525d4c17bfc4ae37e
179 lines
7.9 KiB
Python
179 lines
7.9 KiB
Python
# Copyright (c) 2013 The Johns Hopkins University/Applied Physics Laboratory
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from castellan.tests.unit.key_manager import fake
|
|
import mock
|
|
|
|
from os_brick import encryptors
|
|
from os_brick.tests import base
|
|
|
|
|
|
class VolumeEncryptorTestCase(base.TestCase):
|
|
def _create(self):
|
|
pass
|
|
|
|
def setUp(self):
|
|
super(VolumeEncryptorTestCase, self).setUp()
|
|
self.connection_info = {
|
|
"data": {
|
|
"device_path": "/dev/disk/by-path/"
|
|
"ip-192.0.2.0:3260-iscsi-iqn.2010-10.org.openstack"
|
|
":volume-fake_uuid-lun-1",
|
|
},
|
|
}
|
|
self.root_helper = None
|
|
self.keymgr = fake.fake_api()
|
|
self.encryptor = self._create()
|
|
|
|
|
|
class BaseEncryptorTestCase(VolumeEncryptorTestCase):
|
|
|
|
def _test_get_encryptor(self, provider, expected_provider_class):
|
|
encryption = {'control_location': 'front-end',
|
|
'provider': provider}
|
|
encryptor = encryptors.get_volume_encryptor(
|
|
root_helper=self.root_helper,
|
|
connection_info=self.connection_info,
|
|
keymgr=self.keymgr,
|
|
**encryption)
|
|
self.assertIsInstance(encryptor, expected_provider_class)
|
|
|
|
def test_get_encryptors(self):
|
|
|
|
self._test_get_encryptor('luks',
|
|
encryptors.luks.LuksEncryptor)
|
|
# TODO(lyarwood): Remove the following in Pike
|
|
self._test_get_encryptor('LuksEncryptor',
|
|
encryptors.luks.LuksEncryptor)
|
|
self._test_get_encryptor('os_brick.encryptors.luks.LuksEncryptor',
|
|
encryptors.luks.LuksEncryptor)
|
|
self._test_get_encryptor('nova.volume.encryptors.luks.LuksEncryptor',
|
|
encryptors.luks.LuksEncryptor)
|
|
|
|
self._test_get_encryptor('plain',
|
|
encryptors.cryptsetup.CryptsetupEncryptor)
|
|
# TODO(lyarwood): Remove the following in Pike
|
|
self._test_get_encryptor('CryptsetupEncryptor',
|
|
encryptors.cryptsetup.CryptsetupEncryptor)
|
|
self._test_get_encryptor(
|
|
'os_brick.encryptors.cryptsetup.CryptsetupEncryptor',
|
|
encryptors.cryptsetup.CryptsetupEncryptor)
|
|
self._test_get_encryptor(
|
|
'nova.volume.encryptors.cryptsetup.CryptsetupEncryptor',
|
|
encryptors.cryptsetup.CryptsetupEncryptor)
|
|
|
|
self._test_get_encryptor(None,
|
|
encryptors.nop.NoOpEncryptor)
|
|
# TODO(lyarwood): Remove the following in Pike
|
|
self._test_get_encryptor('NoOpEncryptor',
|
|
encryptors.nop.NoOpEncryptor)
|
|
self._test_get_encryptor('os_brick.encryptors.nop.NoOpEncryptor',
|
|
encryptors.nop.NoOpEncryptor)
|
|
self._test_get_encryptor('nova.volume.encryptors.nop.NoopEncryptor',
|
|
encryptors.nop.NoOpEncryptor)
|
|
|
|
def test_get_error_encryptors(self):
|
|
encryption = {'control_location': 'front-end',
|
|
'provider': 'ErrorEncryptor'}
|
|
self.assertRaises(ValueError,
|
|
encryptors.get_volume_encryptor,
|
|
root_helper=self.root_helper,
|
|
connection_info=self.connection_info,
|
|
keymgr=self.keymgr,
|
|
**encryption)
|
|
|
|
@mock.patch('os_brick.encryptors.LOG')
|
|
def test_error_log(self, log):
|
|
encryption = {'control_location': 'front-end',
|
|
'provider': 'TestEncryptor'}
|
|
provider = 'TestEncryptor'
|
|
try:
|
|
encryptors.get_volume_encryptor(
|
|
root_helper=self.root_helper,
|
|
connection_info=self.connection_info,
|
|
keymgr=self.keymgr,
|
|
**encryption)
|
|
except Exception as e:
|
|
log.error.assert_called_once_with("Error instantiating "
|
|
"%(provider)s: "
|
|
"%(exception)s",
|
|
{'provider': provider,
|
|
'exception': e})
|
|
|
|
@mock.patch('os_brick.encryptors.LOG')
|
|
def test_get_missing_out_of_tree_encryptor_log(self, log):
|
|
provider = 'TestEncryptor'
|
|
encryption = {'control_location': 'front-end',
|
|
'provider': provider}
|
|
try:
|
|
encryptors.get_volume_encryptor(
|
|
root_helper=self.root_helper,
|
|
connection_info=self.connection_info,
|
|
keymgr=self.keymgr,
|
|
**encryption)
|
|
except Exception as e:
|
|
log.error.assert_called_once_with("Error instantiating "
|
|
"%(provider)s: "
|
|
"%(exception)s",
|
|
{'provider': provider,
|
|
'exception': e})
|
|
log.warning.assert_called_once_with("Use of the out of tree "
|
|
"encryptor class %(provider)s "
|
|
"will be blocked with the "
|
|
"Queens release of os-brick.",
|
|
{'provider': provider})
|
|
|
|
@mock.patch('os_brick.encryptors.LOG')
|
|
def test_get_direct_encryptor_log(self, log):
|
|
encryption = {'control_location': 'front-end',
|
|
'provider': 'LuksEncryptor'}
|
|
encryptors.get_volume_encryptor(
|
|
root_helper=self.root_helper,
|
|
connection_info=self.connection_info,
|
|
keymgr=self.keymgr,
|
|
**encryption)
|
|
|
|
encryption = {'control_location': 'front-end',
|
|
'provider': 'os_brick.encryptors.luks.LuksEncryptor'}
|
|
encryptors.get_volume_encryptor(
|
|
root_helper=self.root_helper,
|
|
connection_info=self.connection_info,
|
|
keymgr=self.keymgr,
|
|
**encryption)
|
|
|
|
encryption = {'control_location': 'front-end',
|
|
'provider': 'nova.volume.encryptors.luks.LuksEncryptor'}
|
|
encryptors.get_volume_encryptor(
|
|
root_helper=self.root_helper,
|
|
connection_info=self.connection_info,
|
|
keymgr=self.keymgr,
|
|
**encryption)
|
|
|
|
log.warning.assert_has_calls([
|
|
mock.call("Use of the in tree encryptor class %(provider)s by "
|
|
"directly referencing the implementation class will be "
|
|
"blocked in the Queens release of os-brick.",
|
|
{'provider': 'LuksEncryptor'}),
|
|
mock.call("Use of the in tree encryptor class %(provider)s by "
|
|
"directly referencing the implementation class will be "
|
|
"blocked in the Queens release of os-brick.",
|
|
{'provider':
|
|
'os_brick.encryptors.luks.LuksEncryptor'}),
|
|
mock.call("Use of the in tree encryptor class %(provider)s by "
|
|
"directly referencing the implementation class will be "
|
|
"blocked in the Queens release of os-brick.",
|
|
{'provider':
|
|
'nova.volume.encryptors.luks.LuksEncryptor'})])
|