openstack
/
os-net-config
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(2 comments)

Patch-set: 5
Reviewer: Gerrit User 25241 <25241@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, e77c0bdca907091355fd5f897f3b317c2a2c8351
This commit is contained in:
Gerrit User 25241 2023-12-27 20:12:55 +00:00 committed by Gerrit Code Review
parent 528c970a4a
commit a739de3711
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
a64f319ef85ab494ad308016087b8969c428885b
View File

@ -34,6 +34,23 @@
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "40c9557f_4ed23520",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 25241
},
"writtenOn": "2023-12-27T20:12:55Z",
"side": 1,
"message": "please see the comment below",
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +68,23 @@
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "41157378_7e7f1c7c",
"filename": "os_net_config/sriov_config.py",
"patchSetId": 5
},
"lineNbr": 345,
"author": {
"id": 25241
},
"writtenOn": "2023-12-27T20:12:55Z",
"side": 1,
"message": "@Ivan Kolodyazhny\nFor VF_LAG functionality, you can\u0027t bind the vfs before moving all the pfs to switchdev mode unless you fixed that in the driver. otherwise, it will break the normal VF-LAG functionality.",
"revId": "a64f319ef85ab494ad308016087b8969c428885b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {