openstack/osc-lib
Code Issues Proposed changes

Replace 'assertFalse(a in b)' with 'assertNotIn(a, b)'

Browse Source 
Trivial fix.

Change-Id: Id034f3ddb9be5f1a05e99b5d36b3381edda58ddb
This commit is contained in:
sunyandi 2018-01-19 19:36:45 +08:00 committed by Stephen Finucane
parent 0a7bc3eb8c
commit 239b001a14
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
osc_lib/tests/cli/test_client_config.py
View File

@ -111,8 +111,8 @@ class TestOSCConfig(utils.TestCase):
}
ret_config = self.cloud._auth_v2_arguments(config)
self.assertEqual('fred', ret_config['auth']['username'])
self.assertFalse('tenant_id' in ret_config['auth'])
self.assertFalse('tenant_name' in ret_config['auth'])
self.assertNotIn('tenant_id', ret_config['auth'])
self.assertNotIn('tenant_name', ret_config['auth'])
config = {
'identity_api_version': '3',
@ -124,8 +124,8 @@ class TestOSCConfig(utils.TestCase):
}
ret_config = self.cloud._auth_v2_arguments(config)
self.assertEqual('fred', ret_config['auth']['username'])
self.assertFalse('tenant_id' in ret_config['auth'])
self.assertFalse('tenant_name' in ret_config['auth'])
self.assertNotIn('tenant_id', ret_config['auth'])
self.assertNotIn('tenant_name', ret_config['auth'])
config = {
'identity_api_version': '2',
@ -137,7 +137,7 @@ class TestOSCConfig(utils.TestCase):
}
ret_config = self.cloud._auth_v2_arguments(config)
self.assertEqual('id', ret_config['auth']['tenant_id'])
self.assertFalse('tenant_name' in ret_config['auth'])
self.assertNotIn('tenant_name', ret_config['auth'])
config = {
'identity_api_version': '2',
@ -148,7 +148,7 @@ class TestOSCConfig(utils.TestCase):
},
}
ret_config = self.cloud._auth_v2_arguments(config)
self.assertFalse('tenant_id' in ret_config['auth'])
self.assertNotIn('tenant_id', ret_config['auth'])
self.assertEqual('name', ret_config['auth']['tenant_name'])
def test_auth_v2_ignore_v3(self):
@ -164,7 +164,7 @@ class TestOSCConfig(utils.TestCase):
}
ret_config = self.cloud._auth_v2_ignore_v3(config)
self.assertEqual('fred', ret_config['auth']['username'])
self.assertFalse('project_domain_id' in ret_config['auth'])
self.assertNotIn('project_domain_id', ret_config['auth'])
def test_auth_default_domain_not_set(self):
config = {