openstack/osc-lib
Code Issues Proposed changes

Using assertIsNone() instead of assertEqual(None)

Browse Source 
TrivilalFix

Following OpenStack Style Guidelines:
[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more
specific assertions. As a result, assertIsNone(...) is preferred over
assertEqual(None, ...) and assertIs(..., None)

Change-Id: Ifcac62f400ec15017a1db06ba889ed5e2d6a07f0
This commit is contained in:
luqitao
2017-03-21 22:19:04 -04:00
parent 2819834241
commit 9c60f85ff8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osc_lib/tests/test_utils.py
View File

@@ -498,13 +498,13 @@ class TestFindResource(test_utils.TestCase):
utils.format_dict({'a': 'b', 'c': 'd', 'e': 'f'})) utils.format_dict({'a': 'b', 'c': 'd', 'e': 'f'}))
self.assertEqual(expected, self.assertEqual(expected,
utils.format_dict({'e': 'f', 'c': 'd', 'a': 'b'})) utils.format_dict({'e': 'f', 'c': 'd', 'a': 'b'}))
self.assertEqual(None, utils.format_dict(None)) self.assertIsNone(utils.format_dict(None))
def test_format_list(self): def test_format_list(self):
expected = 'a, b, c' expected = 'a, b, c'
self.assertEqual(expected, utils.format_list(['a', 'b', 'c'])) self.assertEqual(expected, utils.format_list(['a', 'b', 'c']))
self.assertEqual(expected, utils.format_list(['c', 'b', 'a'])) self.assertEqual(expected, utils.format_list(['c', 'b', 'a']))
self.assertEqual(None, utils.format_list(None)) self.assertIsNone(utils.format_list(None))
def test_format_list_of_dicts(self): def test_format_list_of_dicts(self):
expected = "a='b', c='d'\ne='f'" expected = "a='b', c='d'\ne='f'"
@@ -514,7 +514,7 @@ class TestFindResource(test_utils.TestCase):
self.assertEqual(expected, utils.format_list_of_dicts(unsorted_data)) self.assertEqual(expected, utils.format_list_of_dicts(unsorted_data))
self.assertEqual('', utils.format_list_of_dicts([])) self.assertEqual('', utils.format_list_of_dicts([]))
self.assertEqual('', utils.format_list_of_dicts([{}])) self.assertEqual('', utils.format_list_of_dicts([{}]))
self.assertEqual(None, utils.format_list_of_dicts(None)) self.assertIsNone(utils.format_list_of_dicts(None))
def test_format_list_separator(self): def test_format_list_separator(self):
expected = 'a\nb\nc' expected = 'a\nb\nc'