prashkre 0c4718fcb7 Mask passwords only when command execution fails
At many places, processutils.ssh_execute() is being invoked to run
a command over ssh and output returned is parsed to get appropriate
information. In this flow, unsanitized output is being expected
where processutils.ssh_execute() was invoked but found that
output like volume details(containing "password" string in its name)
is being masked away with strutils.mask_password(stdout) even though
no error occured during command execution.

This is regression issue from patch[0]. In this fix, stdout and stderr
in processutils.ssh_execute() will be masked only when
ProcessExecutionError exception is thrown i.e. command execution failed
due to some reasons.

[0] https://github.com/openstack/oslo.concurrency/commit/
ae9e05bfc3

Change-Id: I2ce344330905eef437ef3f89a2a01169a30df8ab
Closes-Bug: #1482382
(cherry picked from commit 21ae27e66d)
2018-02-23 11:40:40 +00:00
2018-01-24 18:03:57 +00:00
2017-03-03 00:02:48 +00:00

Team and repository tags

image

oslo.concurrency

Latest Version

Downloads

The oslo.concurrency library has utilities for safely running multi-thread, multi-process applications using locking mechanisms and for running external processes.

Description
OpenStack library for all concurrency-related code
Readme 4.9 MiB
Languages
Python 100%