oslo.i18n/doc/source/guidelines.rst
Doug Hellmann 5ce463c433 Improve initial documentation
Provide more detailed guidelines based on the info we have in the
wiki at https://wiki.openstack.org/wiki/LoggingStandards#Guidelines

Provide API documentation for the gettextutils module.

Fix up some formatting issues with the contributing page that kept it
from being included in the table of contents.

Add a description to the README.

Other minor section and document title fixes, and remove unused pages.

Change-Id: I1e0a2be2918fe8f5d4194fc5a82b19edb225c1d0
2014-06-23 13:17:45 -04:00

4.9 KiB

Guidelines for Use In OpenStack

Text messages the user sees via exceptions or API calls should be translated using :pyTranslatorFactory.primary <oslo.i18n.gettextutils.TranslatorFactory.primary>, which should be installed as _() in the integration module.

  • usage
  • api

Log Translation

OpenStack supports translating some log levels using separate message catalogs, and so has separate marker functions. These well-known names are used by the build system jobs that extract the messages from the source code and pass it to the translation tool.

Level Function

INFO

_LI()

WARNING

_LW()

ERROR

_LE()

CRITICAL

_LC()

Note

Debug level log messages are not translated.

Choosing a Marker Function

The purpose of the different marker functions is to separate the translatable messages into different catalogs, which the translation teams can prioritize translating. It is important to choose the right marker function, to ensure that strings the user sees will be translated and to help the translation team manage their work load.

Everything marked with _() will be translated. Prioritizing the catalogs created from strings marked with the log marker functions is up to the individual translation teams and their users, but it is expected that they will work on critical and error messages before warning or info.

Examples

_() is preferred for any user facing message, even if it is also going to a log file.

A common pattern is to define a single message object and use it more than once, for the log call and the exception. In that case, use _() because the message is going to appear in an exception that may be presented to the user.

Do not do this:

# WRONG
msg = _LE('There was an error.')
LOG.exception(msg)
raise LocalExceptionClass(msg)

Instead, use this style:

# RIGHT
msg = _('There was an error.')
LOG.exception(msg)
raise LocalExceptionClass(msg)

Except in the case above, _() should not be used for translating log messages. This avoids having the same string in two message catalogs, possibly translated differently by two different translators.

For example, do not do this:

# WRONG
LOG.exception(_('There was an error.'))
raise LocalExceptionClass(_('An error occured.'))

Instead, use this style:

# RIGHT
LOG.exception(_LE('There was an error.'))
raise LocalExceptionClass(_('An error occured.'))

Adding Variables to Translated Messages

Translated messages should not be combined with other literal strings to create partially translated messages. For example, do not do this:

# WRONG
raise ValueError(_('some message') + ': variable=%s') % variable)

Instead, use this style:

# RIGHT
raise ValueError(_('some message: variable=%s') % variable)

Including the variable reference inside the translated message allows the translator to take into account grammar rules, differences in left-right vs. right-left rendering, and other factors to make the translated message more useful to the end user.

Any message with more than one variable should use named interpolation instead of positional, to allow translators to move the variables around in the string to account for differences in grammar and writing direction.

For example, do not do this:

# WRONG
raise ValueError(_('some message: v1=%s v2=%s') % (v1, v2))

Instead, use this style:

# RIGHT
raise ValueError(_('some message: v1=%(v1)s v2=%(v2)s') % {'v1': v1, 'v2': v2})

Adding Variables to Log Messages

String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. For example, do not do this:

# WRONG
LOG.info(_LI('some message: variable=%s') % variable)

Instead, use this style:

# RIGHT
LOG.info(_LI('some message: variable=%s'), variable)

This allows the logging package to skip creating the formatted log message if the message is not going to be emitted because of the current log level.

Avoid Forcing the Translation of Translatable Variables

Translation can also be delayed for variables that potentially contain translatable objects such as exceptions.

Whenever possible translation should not be forced by use of str, unicode, or six.text_type on a message being used with a format string.

For example, do not do this:

# WRONG
LOG.info(_LI('some message: exception=%s', six.text_type(exc)))

Instead, use this style:

# RIGHT
LOG.info(_LI('some message: exception=%s', exc))

This allows the translation of the translatable replacement text to be delayed until the message is translated.