Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
CC: Gerrit User 28522 <28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 28522 2021-05-10 12:08:48 +00:00 committed by Gerrit Code Review
parent 85fc78d0c6
commit ad7883f347

View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "7596c65a_69b7c4bd",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 7,
"author": {
"id": 28522
},
"writtenOn": "2021-05-10T12:08:48Z",
"side": 1,
"message": "Why?\n\nIt could be worth to add some words to justify why we can now remove this module and why we can use the stdlib module instead.\n \nApparently the oslo.utils fnmatch module was originaly implemented to make the fnmatch module thread safe for python 2.7 [1].\n\nWe no longer support py27 since awhile so these changes make sense, however, we need more details in this commit to keep the reason of this removal.\n\nPlease amend your commit message.\n\n[1] https://bugs.python.org/issue23191",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 29
},
"revId": "a4abd514e8a810fee5e0e6b43203dd6f4f303d28",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}