Commit Graph

2473 Commits

Author SHA1 Message Date
Steve Kowalik
58fb5b0675 Add release note about deprecated option removals
Since we have removed a large amount of deprecated options, add a
release note documenting which options have been removed.

Depends-On: https://review.openstack.org/580910
Change-Id: Idb45f691dab77e5bfae841ea45fa167c224c3322
2018-09-14 11:48:28 -06:00
Zuul
ede61c360d Merge "Remove deprecated amqp1 options" 2018-09-14 17:46:26 +00:00
Zuul
14c5bed497 Merge "Remove default_{host,port} deprecated options" 2018-09-14 16:00:45 +00:00
Steve Kowalik
b0d3bfceb8 Remove deprecated rabbit options
Remove the deprecated options rabbit_host, rabbit_port, rabbit_hosts,
rabbit_userid, rabbit_password, rabbit_virtual_host and
rabbit_max_retries which were deprecated in 5.10.0, released during
Ocata.

Change-Id: I39dec568e5de0b653e5af1f196537e09ef126a36
Closes-Bug: #1712394
2018-09-10 15:11:19 -06:00
Steve Kowalik
8881ed4378 Remove deprecated amqp1 options
The amqp1 options allow_insecure_options, username and password are all
deprecated, remove them. allow_insecure_options was deprecated during
Ocata, and the other two were deprecated in 5.22.0, released during
Pike.

Change-Id: I321266c3dba83a38fe6ebd775db2e74c14cc96cd
2018-09-05 16:59:13 +10:00
Steve Kowalik
3b1b08b74a Remove rabbit_durable_queues deprecated option
The rabbit_durable_queues option has been deprecated since amqp code was
moved from olso-incubator to this project, so it's high time it was
removed.

Change-Id: If2450696a43c05c32d35bff26d3dc38423f4330e
2018-09-05 15:35:20 +10:00
Steve Kowalik
4cc1264a18 Remove default_{host,port} deprecated options
The Kafka driver deprecated the kafka_default_host and
kafka_default_port options in 5.10.0, released in Ocata. Remove them.

Change-Id: I206e68ec1624bb6d5d6ba320572530352bbd4378
2018-09-05 14:44:54 +10:00
Zuul
90a5bd5077 Merge "Remove the deprecated ZeroMQ driver" 2018-08-29 14:08:20 +00:00
Zuul
9ab5a2e30e Merge "Fix the coverage tox tests" 2018-08-29 11:57:24 +00:00
Andy Smith
f2fd8d4375 Remove the deprecated ZeroMQ driver
Users of the oslo.messaging RPC communications service must use
the rabbit ("rabbit://...") or AMQP 1.0 ("amqp://...") drivers.

Change-Id: If3474142f1fe99d41d7b4466061ed0e23ca38549
Closes-Bug: 1789259
2018-08-28 16:00:50 -04:00
Kenneth Giusti
d8b0d48055 Fix the coverage tox tests
Change-Id: I45f7269c95807e7a804f116c2d1aed6baf9f46e2
2018-08-20 15:20:47 -04:00
Kenneth Giusti
d9866029a2 Avoid logging passwords on connection events
Change-Id: I15c8c4a1177c363283281d2fed63545658eda5de
Closes-Bug: #1787214
2018-08-20 12:31:16 -04:00
Doug Hellmann
a4a8eef010 add lib-forward-testing-python3 test job
This is a mechanically generated patch to add a functional test job
running under Python 3 as part of the python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: Ib99a323861c0fdb548287446ab25e0516a7c182e
Story: #2002586
Task: #24322
2018-08-11 18:20:14 -04:00
Doug Hellmann
deec8c1f13 add python 3.6 unit test job
This is a mechanically generated patch to add a unit test job running
under Python 3.6 as part of the python3-first goal.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I1da69d0b77a3970c727b60de4c341552970fbb47
Story: #2002586
Task: #24322
2018-08-07 16:17:34 -04:00
Doug Hellmann
818fd688a2 import zuul job settings from project-config
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html

Change-Id: I0401a53945ad87e1dc046904054b12e2b106a3e8
Story: #2003250
2018-08-03 17:45:00 -04:00
Andras Kovi
d8fa6d5edf Call listener stop only if listener is initialized
Change-Id: I1303d74af7a242edefe774d8f5e12e63614c0158
Closes-Bug: #1785048
2018-08-02 13:28:42 +02:00
Zuul
3a725f957b Merge "Update reno for stable/rocky" 2018-08-01 20:57:30 +00:00
Zuul
01a37733eb Merge "Issue blocking ACK for RPC requests from the consumer thread" 2018-07-30 15:48:21 +00:00
59c47233f5 Update reno for stable/rocky
Change-Id: I1a8834b95487805805395e919e2c6cdc435522b0
2018-07-26 12:38:43 +00:00
Dirk Mueller
e233334a9e Remove setting of DEVSTACK_GATE_EXERCISES
This defaults to 0 anyway, and is being removed as the devstack
excercises are being removed. see https://review.openstack.org/#/c/581377/

Change-Id: Ifb147f9fb2071724a9eaf306273276db65125cf7
2018-07-17 10:46:55 +02:00
Daniel Alvarez
7dc7684311 Bump py-amqp to >= 2.3.0
Due to the bug below we want to have py-amqp>=2.3.0 so that connecting
to rabbit endpoints don't timeout when relying on /etc/hosts entries.
Closes-Bug: 1780992

Change-Id: Ia2c1114cb0f8d480695197714f7c6293751430dd
2018-07-11 15:22:21 +02:00
Kenneth Giusti
26b0be585a Issue blocking ACK for RPC requests from the consumer thread
The patch for https://review.openstack.org/#/c/436958/ fixed a
threading problem by moving the ack back to the polling
thread. However the RPC server expects to catch any failures of the
ACK and abort the request.  This patch adds the ACK error handling
back to the polling thread.

This patch is based heavily off the original work done by Mehdi
Abaakouk (sileht).

Change-Id: I708c3d6676b974d8daac6817c15f596cdf35817b
Closes-Bug: #1695746
2018-07-11 08:59:35 -04:00
Zuul
b97481ce19 Merge "No longer allow redundant calls to server start()" 2018-07-10 10:24:58 +00:00
Zuul
8047377562 Merge "py37: deal with Exception repr changes" 2018-07-09 22:13:18 +00:00
Zuul
1f0682bc59 Merge "py37: drop use of 'async' as parameter name" 2018-07-09 17:38:37 +00:00
Zuul
9be8c1a6e2 Merge "Do not access the connection's socket during error callback" 2018-07-06 21:21:00 +00:00
Kenneth Giusti
361669764f Do not access the connection's socket during error callback
The _get_connection_info() method attempts to gather debug information
from the connection, and will reach into the amqp channel to get the
local (client's) TCP port number via the 'sock' property.

If _get_connection_info() is called from autoretry's on_error handler
the 'sock' property notices that the transport is not set and attempts
to re-connect.  amqp has deprecated this reconnect behavior, and in
any case the client's socket is irrelevant since the connection may
not be valid at this point.

Closes-Bug: #1745166
Change-Id: I3c42f8463605927f6f94d6c3a7f05e584476abc1
2018-07-06 12:15:53 -04:00
Kenneth Giusti
679572272e Fix debug log message - missing argument
Change-Id: I811c6051808a34fa5235b47e56ee3b41cb35adad
2018-07-06 11:41:07 -04:00
Zuul
cd2c63753b Merge "Remove transport aliases support" 2018-07-05 18:26:23 +00:00
James Page
dfb83f4948 py37: deal with Exception repr changes
Under Python 3.7, a trailing comma is no longer added to
the init parameters generated by a repr() call:

    >>> repr(Exception('It Works'))
    "Exception('It Works')"

vs

    >>> repr(Exception('It Works'))
    "Exception('It Works',)"

Support pre and post Python 3.7 formats in test cases for
notification middleware.

Change-Id: I30a46ae82f2cc1b529287c049aa5fc6d987e2538
2018-07-05 06:38:38 -05:00
James Page
5626782fac py37: drop use of 'async' as parameter name
Python 3.7 does not allow the use of 'async' as
a parameter name or object attribute; update
occurrences to use a different name.

This is inline with PEP-492, where await and async
are keywords.

Change-Id: I73efcafab1e0832a0ada95f6c12cb6a659dfcf27
2018-07-05 06:09:37 -05:00
Steve Kowalik
e55f419017 Remove transport aliases support
To facilitate removing rpc_backend support, disentangle the aliases
code by removing it to simplify the code and the tests. Aliases were
first depreacted in 5.20.0 during Pike.

Change-Id: I7d80cd050ce1eca2c6b6c38f0fac29d090b90bf3
Closes-Bug: #1424728
2018-07-05 15:58:05 +10:00
Vu Cong Tuan
bcbebb7d6a Moving stestr to correct package order in test-requirements.txt
As the comment from Stephen [1],
after moving to stestr, the package should be in exact position
where testrepository is removed.

[1] https://review.openstack.org/#/c/579743/2/test-requirements.txt@16

Change-Id: Ib748e4f8ba1263f2c6475c8641c800b7df872b88
2018-07-05 08:28:33 +07:00
Zuul
9e61ad5405 Merge "Fix the bandit security linter test" 2018-07-04 18:04:50 +00:00
Zuul
2ca8a15905 Merge "Switch to stestr" 2018-07-04 13:03:07 +00:00
Vu Cong Tuan
7e5be7c54c Switch to stestr
According to Openstack summit session [1],
stestr is maintained project to which all Openstack projects should migrate.
Let's switch to stestr as other projects have already moved to it.

[1] https://etherpad.openstack.org/p/YVR-python-pti

Change-Id: I89b785c91738ab62e3f42da42c431b9df8ccfd70
2018-07-04 08:33:49 +07:00
Zuul
8a5da2c28f Merge "Enable RPC call monitoring in AMQP 1.0 driver" 2018-07-04 00:04:17 +00:00
Kenneth Giusti
a84c946767 No longer allow redundant calls to server start()
This has been deprecated since before Ocata.

Change-Id: I659cc690c0a5d4f82349c7c4882c34c9c82e8a8a
Closes-Bug: #1712397
2018-07-03 13:43:40 -04:00
Kenneth Giusti
ae9e673887 Fix the bandit security linter test
Add the bandit security linter test to the pep8 target

Change-Id: I9324b9d9df77fd05c2e10bb48d7ccf8b4c634525
2018-07-02 13:16:11 -04:00
Dougal Matthews
044e6f20e6 Replace 'raise StopIteration' with 'return'
With PEP 479, the behaviour of StopIteration is changing. Raising it to
stop a generator is considered incorrect and from Python 3.7 this will
cause a RuntimeError. The PEP recommends using the return statement.

More details: https://www.python.org/dev/peps/pep-0479/#examples-of-breakage

Change-Id: Ib27581fccbbf14c082fb919d8b6edea1ac83e3c0
2018-06-29 14:39:46 +01:00
Steve Kowalik
5de0494739 Remove fake_rabbit configuration option
The fake_rabbit configuration option has been deprecated since the
release of 1.5.0 in late 2014. Finally remove it, and its test.

Change-Id: I014c2012cca0f289de0d95b9bb35bbde7f61d2ee
2018-06-26 15:49:27 +10:00
melissaml
648ad56c86 Add release notes link to README
Change-Id: I082305a2e11e26115271322b49b3f9b2e79e3dd0
2018-06-21 13:16:36 +08:00
Kenneth Giusti
8cc258b93c Add ZeroMQ deprecation release note
Change-Id: I32d36c986567646d9e470ce417b3e04776197e94
2018-06-15 15:27:49 -04:00
Zuul
d666aa8f03 Merge "Fix oslo messaging gating" 2018-06-14 22:05:33 +00:00
Mehdi Abaakouk
0e2e50aad8 Fix oslo messaging gating
This change fixes the oslo.messaging gate for rabbit/amqp1/kafka.

Change-Id: I7c80b89231ca0a6a9e38aecc9e744da5d7227f00
2018-06-14 12:46:08 +02:00
Kenneth Giusti
684e3f0e41 Enable RPC call monitoring in AMQP 1.0 driver
The call monitoring feature was introduced in commit
b34ab8b1cc for RabbitMQ.  This patch
enables the feature on the AMQP 1.0 driver - currently the only other
driver that supports RPC.

Change-Id: Ic787696852690b59779fb4716aec1e78c48bbe6a
2018-06-13 11:01:38 -04:00
Kenneth Giusti
42f0358d5d Mark the ZeroMQ driver deprecated
As per the Dublin 2018 PTG decision:

http://lists.openstack.org/pipermail/openstack-dev/2018-March/128055.html

Change-Id: I1cda5dffbc29aad5fea001a79562db7c144a339b
2018-06-11 15:11:31 -04:00
Zuul
e0835c5ba8 Merge "fix tox python3 overrides" 2018-06-08 13:59:07 +00:00
Doug Hellmann
87cafdf804 fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I02ef155ef47a5eaddf9de902ad3608bee677fbcf
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
2018-06-07 17:40:38 -04:00
Zuul
9180695784 Merge "Correct usage of transport_url in example" 2018-06-06 20:07:32 +00:00