openstack/oslo.service
Code Issues Proposed changes

Merge "Make signal handling order predictable"

Browse Source
This commit is contained in:
Zuul
2024-03-19 16:33:21 +00:00
committed by Gerrit Code Review
parent 8ae4455ec7 d026081ca4
commit bc38e43044
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
oslo_service/service.py
View File

@@ -142,7 +142,7 @@ class SignalHandler(metaclass=Singleton):
self.signals_to_name = dict(
(sigval, name)
for (name, sigval) in self._signals_by_name.items())
self._signal_handlers = collections.defaultdict(set)
self._signal_handlers = collections.defaultdict(list)
self.clear()
def clear(self):
@@ -158,7 +158,7 @@ class SignalHandler(metaclass=Singleton):
if not self.is_signal_supported(sig):
return
signo = self._signals_by_name[sig]
self._signal_handlers[signo].add(handler)
self._signal_handlers[signo].append(handler)
signal.signal(signo, self._handle_signal)
def _handle_signal(self, signo, frame):
@@ -237,7 +237,7 @@ class SignalHandler(metaclass=Singleton):
self.__hub_module_file = sys.modules[hub.__module__].__file__
def _handle_signal_cb(self, signo, frame):
for handler in self._signal_handlers[signo]:
for handler in reversed(self._signal_handlers[signo]):
handler(signo, frame)
def is_signal_supported(self, sig_name):