openstack/ovn-octavia-provider
Code Issues Proposed changes
350a26b2d5
ovn-octavia-provider/HACKING.rst
Brian Haley 6ed2660676 Add a hacking check for importing mock library 
We should only be using unittest.mock since we're python3-only,
so add and enable a hacking check that will catch it.

Change-Id: I64847f329ee3e1a3377a8c63df90c697d8b74c86
2020-06-09 14:46:36 -04:00

884 B
Raw Blame History

ovn-octavia-provider Style Commandments

Read the OpenStack Style Commandments https://docs.openstack.org/hacking/latest/

Below you can find a list of checks specific to this repository.

  • [N322] Detect common errors with assert_called_once_with
  • [N328] Detect wrong usage with assertEqual
  • [N330] Use assertEqual(empty, observed) instead of

    assertEqual(observed, empty)

  • [N331] Detect wrong usage with assertTrue(isinstance()).
  • [N332] Use assertEqual(expected_http_code, observed_http_code) instead of

    assertEqual(observed_http_code, expected_http_code).

  • [N343] Production code must not import from ovn_octavia_provider.tests.*
  • [N344] Python 3: Do not use filter(lambda obj: test(obj), data). Replace it

    with [obj for obj in data if test(obj)].

  • [N347] Test code must not import mock library