openstack/placement
Code Issues Proposed changes

Merge "hacking: Always use 'assertIs(Not)None'"

Browse Source
This commit is contained in:
Jenkins 2016-09-26 13:12:34 +00:00 committed by Gerrit Code Review
commit 808604ffdd
1 changed files with 2 additions and 2 deletions

4
HACKING.rst

@ -26,8 +26,8 @@ Nova Specific Commandments
assertIsInstance(A, B).
- [N317] Change assertEqual(type(A), B) by optimal assert like
assertIsInstance(A, B)
- [N318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like
assertIsNone(A)
- [N318] Change assertEqual(A, None) or assertIs(A, None) to optimal assert
like assertIsNone(A)
- [N319] Validate that debug level logs are not translated.
- [N320] Setting CONF.* attributes directly in tests is forbidden. Use
self.flags(option=value) instead.