openstack/project-config
Code Issues Proposed changes

Improve gerrit checks messages

Browse Source 
For tools/check_valid_gerrit_projects.py:
* Improve one error message to mention the project as well.

For tools/check_valid_gerrit_config.sh:
* Remove output for each ACL we check, we output the entry if it's
  wrong. But with 800+ ACL lines, we should not output 800+ lines of
  progress and thus make it hard to find the one failing line.

Change-Id: I4434c0f0bf65a1eb69889a2362c1abae7119fdd7
This commit is contained in:
Andreas Jaeger 2016-09-10 18:39:00 +02:00
parent 6e2d3daadd
commit 5e7ad13490
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/check_valid_gerrit_config.sh
View File

@ -14,7 +14,6 @@ function check_team_acl {
local failure=0
for config in $configs_list; do
echo "Checking $config file..."
$OLDPWD/tools/normalize_acl.py $config all > $TMPDIR/normalized
if ! diff -u $config $TMPDIR/normalized >>config_failures;

6
tools/check_valid_gerrit_projects.py
View File

@ -129,9 +129,9 @@ def main():
# sort of job-description (e.g. "foo-devstack-bar") or
# a url ("foo.openstack.org")
if re.search(r'(?<![-.])\b%s\b' % word, description):
print("ERROR: description '%s': contains wrong word, "
"it should be '%s'" %
(description, should_be))
print("ERROR: project %s, description '%s': "
"contains wrong word '%s', it should be '%s'" %
(name, description, word, should_be))
found_errors += 1
if not description and repo_group in DESCRIPTION_REQUIRED: