Fix translation subunit upload

The run job ended and did not upload the subunit file in case of
failure.

Move the subunit upload into it's own post-run script so that it runs
everytime.

Change-Id: I42c3f52e995e8c3c47efbf07c48eaaf66dbfa59b

playbooks/translation/post.yaml

@@ -0,0 +1,3 @@
+- hosts: all
+  roles:
+    - fetch-translations-subunit-output

playbooks/translation/propose-translation-update.yaml

@@ -1,4 +1,3 @@
----
 - hosts: all
   roles:
     - prep-zanata
@@ -9,7 +8,3 @@
       command: "{{ ansible_user_dir }}/scripts/propose_translation_update.sh {{ zuul.project.short_name }} {{ zuul.branch }} {{ zuul.job }}"
       args:
         chdir: "{{ zuul.project.src_dir }}"
-
-- hosts: all
-  roles:
-    - fetch-translations-subunit-output

playbooks/translation/upstream-translation-update.yaml

@@ -1,4 +1,3 @@
----
 - hosts: all
   roles:
     - prep-zanata
@@ -13,4 +12,3 @@
 - hosts: all
   roles:
     - fetch-translation-output
-    - fetch-translations-subunit-output

zuul.d/jobs.yaml

@@ -1226,7 +1226,9 @@
       Push strings for translation to translation server.
     pre-run: playbooks/translation/pre.yaml
     run: playbooks/translation/upstream-translation-update.yaml
-    post-run: playbooks/publish/openstack-artifacts.yaml
+    post-run:
+      - playbooks/translation/post.yaml
+      - playbooks/publish/openstack-artifacts.yaml
     semaphore: translations
     vars:
       fileserver_leading_path: translation-source
@@ -1246,6 +1248,7 @@
       proposed change.
     pre-run: playbooks/translation/pre.yaml
     run: playbooks/translation/propose-translation-update.yaml
+    post-run: playbooks/translation/post.yaml
     vars:
       constraints_file: '{{ ansible_user_dir }}/src/git.openstack.org/openstack/requirements/upper-constraints.txt'
     semaphore: translations