Use "Rollcall-Vote" for TC and infra-council
Adopt the idea that a review label name should be as widely-applicable as possible for a given concept so that different repos with similar needs will end up sharing columns in the user interface. Since the TC and infra-specs repos both need "votes from the people who are members of the committee" as a review label (while preserving the ability for non-members to leave their feedback as +/- entries in code-review), have them share the name "Rollcall Vote". This will cause them both to appear in the "RV" column in Gerrit change lists. Simply "Vote" is an option worth considering, but it is not clear how "Vote" is different from Code-Review. Change-Id: Id53d1bea7f53b92009ba6e9274162b8ffa3b2b92
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
[access "refs/heads/*"]
|
||||
abandon = group infra-core
|
||||
label-Council-Vote = -2..+1 group infra-core
|
||||
label-Council-Vote = -1..+1 group infra-council
|
||||
label-Rollcall-Vote = -2..+1 group infra-core
|
||||
label-Rollcall-Vote = -1..+1 group infra-council
|
||||
label-Workflow = -1..+1 group infra-ptl
|
||||
|
||||
[label "Code-Review"]
|
||||
@@ -14,7 +14,7 @@ value = 0 No score
|
||||
value = +1 Looks good to me
|
||||
value = +2 Unused +2
|
||||
|
||||
[label "Council-Vote"]
|
||||
[label "Rollcall-Vote"]
|
||||
defaultValue = 0
|
||||
function = AnyWithBlock
|
||||
value = -2 Veto
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
[access "refs/heads/*"]
|
||||
abandon = group tech-committee-chair
|
||||
exclusiveGroupPermissions = abandon label-Workflow
|
||||
label-TC-Vote = -1..+1 group tech-committee
|
||||
label-Rollcall-Vote = -1..+1 group tech-committee
|
||||
label-Workflow = -1..+1 group tech-committee-chair
|
||||
|
||||
[access "refs/tags/*"]
|
||||
@@ -17,7 +17,7 @@ value = 0 No score
|
||||
value = +1 Looks good to me
|
||||
value = +2 Unused +2
|
||||
|
||||
[label "TC-Vote"]
|
||||
[label "Rollcall-Vote"]
|
||||
defaultValue = 0
|
||||
function = NoOp
|
||||
value = -1 No
|
||||
|
||||
Reference in New Issue
Block a user