openstack/project-config
Code Issues Proposed changes

Merge "Remove global vars from check_valid_gerrit_projects.py"

Browse Source
This commit is contained in:
Jenkins 2015-10-23 11:15:21 +00:00 committed by Gerrit Code Review
commit 83818ce335
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/check_valid_gerrit_projects.py
View File

@ -23,8 +23,6 @@ import sys
import tempfile
import yaml
found_errors = 0
@contextlib.contextmanager
def tempdir():
@ -36,7 +34,7 @@ def tempdir():
def check_repo(repo_path):
global found_errors
found_errors = 0
print("Checking git repo '%s':" % repo_path)
with tempdir() as repopath:
@ -59,10 +57,11 @@ def check_repo(repo_path):
print(" Found no tags.")
# Just an empty line for nicer formatting
print("")
return found_errors
def main():
global found_errors
found_errors = 0
parser = argparse.ArgumentParser()
parser.add_argument('-v', '--verbose',
@ -124,7 +123,7 @@ def main():
# but not git@
upstream = p.get('upstream')
if upstream and 'track-upstream' not in p.get('options', []):
check_repo(upstream)
found_errors += check_repo(upstream)
if upstream:
for prefix in VALID_SCHEMES:
if upstream.startswith(prefix):