openstack
/
project-config
Code Issues Proposed changes

Extend ACL checks to OpenStack namespace. 

Change-Id: I0ac6ee99391f218fa467b58bf39934c6c68d1808
This commit is contained in:
armando-migliaccio 2014-12-16 13:43:26 -08:00
parent 40b786bf55
commit af09d7ca4b
2 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/check_valid_gerrit_config.sh
View File

@ -25,7 +25,7 @@ function check_team_acl {
} }
# Add more namespaces here, if necessary # Add more namespaces here, if necessary
for namespace in stackforge openstack-dev; do for namespace in stackforge openstack openstack-dev; do
check_team_acl "${CONFIGS_LIST_BASE}${namespace}" check_team_acl "${CONFIGS_LIST_BASE}${namespace}"
done done

22
tools/normalize_acl.py
View File

@ -111,14 +111,26 @@ if '6' in transformations:
acl[section] = newsection acl[section] = newsection
if '7' in transformations: if '7' in transformations:
special_teams = ("core", "milestone", "Users", "admins") special_projects = (
'ossa',
)
special_teams = (
'admins',
'committee',
'core',
'maint',
'Managers',
'milestone',
'Users',
)
for section in acl.keys(): for section in acl.keys():
newsection = [] newsection = []
for option in acl[section]: for option in acl[section]:
if ("refs/heads" in section and "group" in option if ('refs/heads' in section and 'group' in option
and "-2..+2" in option and '-2..+2' in option
and not any(x in option for x in special_teams)): and not any(x in option for x in special_teams)
option = "%s%s" % (option, "-core") and not any(x in aclfile for x in special_projects)):
option = '%s%s' % (option, '-core')
newsection.append(option) newsection.append(option)
acl[section] = newsection acl[section] = newsection