openstack/project-config
Code Issues Proposed changes

gerrit/acl : submit-requirements for deprecated NoOp function

Browse Source 
The submit functions are deprecated in Gerrit 3.7 and replaced with
submit-requirements.

This starts at the replacement with ACL's currently using the NoOp
function.

This implements the migrations steps encded with [1] upstream.  The
function is changed to NoBlock, and a "non-applicable"
submit-requirement of "applicableIf = is:false" and "submittableIf =
is:true" is added, with the same name as the label.

Since we are matching the upstream rules for idempotence -- a
submit-requirement with the same name as the label, we will avoid
future upgrades modifying our ACL's and getting them out of sync with
what we have in project-config.

From a user's point-of-view, this change itself should be a no-op.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/339542

Change-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc
This commit is contained in:
Ian Wienand
2023-03-01 16:11:24 +11:00
parent f346b72eb6
commit dda3b6098e
11 changed files with 84 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit/acls/opendev/infra-specs.config
View File

@@ -7,7 +7,7 @@ label-Workflow = -1..+1 group infra-ptl
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = -2 Unused -2
value = -1 This patch needs further work before it can be merged
value = 0 No score
@@ -29,3 +29,8 @@ requireChangeId = true
[submit]
mergeContent = true
[submit-requirement "Code-Review"]
applicableIf = is:false
description = Informational vote on current revision
submittableIf = is:true

14
gerrit/acls/openinfra/transparency-policy.config
View File

@@ -14,7 +14,7 @@ createSignedTag = group transparency-committee-chair
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = -2 Unused -2
value = -1 This patch needs further work before it can be merged
value = 0 No score
@@ -24,7 +24,7 @@ value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = -1 No
value = 0 Abstain
value = +1 Yes
@@ -35,3 +35,13 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Code-Review"]
applicableIf = is:false
description = Informational vote on current revision
submittableIf = is:true
[submit-requirement "Rollcall-Vote"]
applicableIf = is:false
description = An informational vote from team members
submittableIf = is:true

14
gerrit/acls/openstack/governance.config
View File

@@ -18,7 +18,7 @@ createSignedTag = group tech-committee-chair
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = -2 Unused -2
value = -1 This patch needs further work before it can be merged
value = 0 No score
@@ -28,7 +28,7 @@ value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = -1 No
value = 0 Abstain
value = +1 Yes
@@ -39,3 +39,13 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Code-Review"]
applicableIf = is:false
description = An informational vote on this revision
submittableIf = is:true
[submit-requirement "Rollcall-Vote"]
applicableIf = is:false
description = An informational vote from team members
submittableIf = is:true

7
gerrit/acls/openstack/nova-specs.config
View File

@@ -11,7 +11,7 @@ label-Workflow = -1..+1 group nova-specs-core
[label "Review-Priority"]
copyCondition = is:ANY
defaultValue = 0
function = NoOp
function = NoBlock
value = 0 Default Priority
value = +1 Contributor Review Promise
value = +2 Core Review Promise
@@ -22,3 +22,8 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Review-Priority"]
applicableIf = is:false
description = Review Priority
submittableIf = is:true

7
gerrit/acls/openstack/nova.config
View File

@@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
defaultValue = 0
function = NoOp
function = NoBlock
value = 0 Default Priority
value = +1 Contributor Review Promise
value = +2 Core Review Promise
@@ -41,3 +41,8 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Review-Priority"]
applicableIf = is:false
description = Review Priority
submittableIf = is:true

7
gerrit/acls/openstack/openstacksdk.config
View File

@@ -27,7 +27,7 @@ label-Workflow = -1..+1 group stable-maint-core
[label "Allow-Post-Review"]
defaultValue = 0
function = NoOp
function = NoBlock
value = 0 Abstain
value = +1 Approved for Zuul Post Review Pipeline
@@ -37,3 +37,8 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Allow-Post-Review"]
applicableIf = is:false
description = Allow Post Review
submittableIf = is:true

7
gerrit/acls/openstack/os-vif.config
View File

@@ -32,7 +32,7 @@ label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
defaultValue = 0
function = NoOp
function = NoBlock
value = 0 Default Priority
value = +1 Contributor Review Promise
value = +2 Core Review Promise
@@ -43,3 +43,8 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Review-Priority"]
applicableIf = is:false
description = Review Priority
submittableIf = is:true

7
gerrit/acls/openstack/placement.config
View File

@@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
defaultValue = 0
function = NoOp
function = NoBlock
value = 0 Default Priority
value = +1 Contributor Review Promise
value = +2 Core Review Promise
@@ -41,3 +41,8 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Review-Priority"]
applicableIf = is:false
description = Review Priority
submittableIf = is:true

7
gerrit/acls/openstack/python-novaclient.config
View File

@@ -29,7 +29,7 @@ label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
defaultValue = 0
function = NoOp
function = NoBlock
value = 0 Default Priority
value = +1 Contributor Review Promise
value = +2 Core Review Promise
@@ -40,3 +40,8 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Review-Priority"]
applicableIf = is:false
description = Review Priority
submittableIf = is:true

7
gerrit/acls/openstack/release-test.config
View File

@@ -10,7 +10,7 @@ label-Workflow = -1..+1 group releases-core
[label "PTL-Approved"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = 0 Abstain
value = +1 Approved by PTL
@@ -20,3 +20,8 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "PTL-Approved"]
applicableIf = is:false
description = Marked as approved by the PTL
submittableIf = is:true

14
gerrit/acls/starlingx/governance.config
View File

@@ -14,7 +14,7 @@ createSignedTag = group stx-tech-steering-committee-secretary
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = -2 Unused -2
value = -1 This patch needs further work before it can be merged
value = 0 No score
@@ -24,7 +24,7 @@ value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
function = NoBlock
value = -1 No
value = 0 Abstain
value = +1 Yes
@@ -35,3 +35,13 @@ requireContributorAgreement = true
[submit]
mergeContent = true
[submit-requirement "Code-Review"]
applicableIf = is:false
description = Code Review votes are ignored
submittableIf = is:true
[submit-requirement "Rollcall-Vote"]
applicableIf = is:false
description = An informational vote from team members
submittableIf = is:true