Commit Graph

3 Commits

Author SHA1 Message Date
James E. Blair
d1673c9063 Fix failure detection in irc access check
Two problems are corrected:

1) If a channel is not registered with chanserv, consider it an
access failure.

2) The failure flag was being reset on every successful private
message.  That was intended to ensure that we failed if we were
unable to communicate with ChanServ.  But the logic was flawed.
Correct this by treating the failure flag as trinary.  On the
first channel where we have verified access is okay, set the flag
to indicate that we have not failed, iff the flag has not already
been set.  So now either failure to communicate with ChanServ or
an actual access failure will cause it to exit 1.

Change-Id: I8d51b706ed6f499827f8046ab4522b342589cb90
2015-03-19 08:12:57 +01:00
Andreas Jaeger
f8788e2e27 Ensure that gerritbot channels are in accessbot
Add new test that checks that channels mentioned in gerritbot are also
in accessbot.

Enhance the irc tox target so that it runs the checks, and update Zuul
so that the job is run for changes to gerritbot.

Add channels openstack-mistral and puppet-openstack to accessbot,
openstackinfra now has access to the channels. These two channels are
already in gerritbot.

Make check_irc_access.py script executable.

Change-Id: Ic68ba9a1c60854e68817fcadb1a5df2144944af7
2015-03-06 12:51:24 +01:00
James E. Blair
312e958fb1 Fix test jobs
Make the necessary changes for the jobs ported over from infra/config
to work in this repo.

Also, make the irc access job voting.

Add a .gitignore file.

Change-Id: If3b6c214881205a25e8148c23c3411338b66ef90
2014-09-25 16:40:07 +00:00