openstack
/
puppet-barbican
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 7888 \u003c7888@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
This commit is contained in:
Gerrit User 9816 2023-06-15 22:15:03 +00:00 committed by Gerrit Code Review
parent 12e24842bc
commit 536f0ecf38
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
d3724a40b23e2ab952529cc7dcdf452e133b314b
View File

@ -46,6 +46,30 @@
},
"revId": "d3724a40b23e2ab952529cc7dcdf452e133b314b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dbc394ac_8207dbd6",
"filename": "manifests/keystone/notification.pp",
"patchSetId": 1
},
"lineNbr": 62,
"author": {
"id": 9816
},
"writtenOn": "2023-06-15T22:15:03Z",
"side": 1,
"message": "yes Enum. We can probably define OSBoolean which allows SERVICE DEFAULT as well as actual Boolean and String representation, but again we need to agree with the patterns we allow for each option types so I\u0027d avoid creating the type now and focus on removing the validate_legacy.",
"parentUuid": "8500bd3c_d7c921ad",
"range": {
"startLine": 62,
"startChar": 25,
"endLine": 62,
"endChar": 53
},
"revId": "d3724a40b23e2ab952529cc7dcdf452e133b314b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}