openstack
/
puppet-ceilometer
Code Issues Proposed changes

Password should be secured 

As messaging_urls option contains rabbit_password value, it should
be secured.

Change-Id: I503180280a5558d27c00368e9949aaed52151e79
Closes-Bug: #1676708
This commit is contained in:
ZhongShengping 2017-03-28 16:21:30 +08:00
parent 2e25568305
commit 015fd676e4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/agent/notification.pp
View File

@ -124,6 +124,6 @@ class ceilometer::agent::notification (
'notification/store_events' : value => $store_events;
'notification/disable_non_metric_meters': value => $disable_non_metric_meters;
'notification/workers' : value => $notification_workers;
'notification/messaging_urls' : value => $messaging_urls;
'notification/messaging_urls' : value => $messaging_urls, secret => true;
}
}

2
spec/classes/ceilometer_agent_notification_spec.rb
View File

@ -109,7 +109,7 @@ describe 'ceilometer::agent::notification' do
it 'configures two messaging urls' do
is_expected.to contain_ceilometer_config('notification/messaging_urls').with_value(
['rabbit://rabbit_user:password@localhost/nova', 'rabbit://rabbit_user:password@localhost/neutron']
)
).with_secret(true)
end
end