openstack/puppet-ceilometer
Code Issues Proposed changes

Remove ceilometer client class

Browse Source 
The ceilometer client has been retired upstream and the class has been
previously deprecated. Since the package may be going away, we need to
remove the client class.

https://review.openstack.org/#/c/522183/

Change-Id: I3e10b80d5115b32bb4aa480276303ac6136f175f
This commit is contained in:
Alex Schultz 2017-11-28 14:14:06 -07:00
parent 78b9e1d743
commit cec993b713
6 changed files with 5 additions and 66 deletions

1
README.md

@ -56,7 +56,6 @@ class { '::ceilometer':
class { '::ceilometer::keystone::auth':
password => 'a_big_secret',
}
class { '::ceilometer::client': }
class { '::ceilometer::collector': }
class { '::ceilometer::expirer': }
class { '::ceilometer::agent::polling': }

1
examples/ceilometer_with_gnocchi.pp

@ -13,7 +13,6 @@ class { '::ceilometer::db':
class { '::ceilometer::keystone::auth':
password => 'a_big_secret',
}
class { '::ceilometer::client': }
class { '::ceilometer::expirer': }
class { '::ceilometer::agent::polling': }
class { '::ceilometer::agent::notification': }

28
manifests/client.pp

@ -1,28 +0,0 @@
# == Class: ceilometer::client
#
# Installs the ceilometer python library.
#
# === Parameters:
#
# [*ensure*]
# (Optional) Ensure state for pachage.
# Defaults to 'present'.
#
class ceilometer::client (
$ensure = 'present'
) {
include ::ceilometer::deps
include ::ceilometer::params
warning('This class is deprecated and will be removed in future releases.
Use gnocchi, aodh or panko clients to access data instead.')
package { 'python-ceilometerclient':
ensure => $ensure,
name => $::ceilometer::params::client_package_name,
tag => 'openstack',
}
}

5
releasenotes/notes/ceilometer-client-removal-e36598e0e1d66231.yaml Normal file

@ -0,0 +1,5 @@
---
upgrade:
- |
Ceilometer client has been removed from the upstream so the ceilomter::client
class has been removed.

1
spec/acceptance/ceilometer_wsgi_apache_spec.rb

@ -50,7 +50,6 @@ describe 'ceilometer with mysql' do
class { '::ceilometer::db::sync':
extra_params => '--skip-gnocchi-resource-types',
}
class { '::ceilometer::client': }
class { '::ceilometer::expirer': }
class { '::ceilometer::agent::central': }
class { '::ceilometer::agent::notification': }

35
spec/classes/ceilometer_client_spec.rb

@ -1,35 +0,0 @@
require 'spec_helper'
describe 'ceilometer::client' do
shared_examples_for 'ceilometer client' do
it { is_expected.to contain_class('ceilometer::deps') }
it { is_expected.to contain_class('ceilometer::params') }
it 'installs ceilometer client package' do
is_expected.to contain_package('python-ceilometerclient').with(
:ensure => 'present',
:name => platform_params[:client_package_name],
:tag => 'openstack',
)
end
end
on_supported_os({
:supported_os => OSDefaults.get_supported_os
}).each do |os,facts|
context "on #{os}" do
let (:facts) do
facts.merge!(OSDefaults.get_facts())
end
let :platform_params do
{ :client_package_name => 'python-ceilometerclient' }
end
it_behaves_like 'ceilometer client'
end
end
end